Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add routes for help sections #5667

Merged
merged 3 commits into from Feb 14, 2015

Conversation

@svbergerem
Copy link
Member

commented Feb 14, 2015

Fixes #5529. I used the code @AugierLe42e wrote in #5603 and fixed the jasmine tests.

'account_and_data_management',
'miscellaneous'
];
spyOn(app.router, 'navigate');

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Feb 14, 2015

'spyOn' is not defined.

This comment has been minimized.

Copy link
@salbertson

salbertson Feb 14, 2015

You can add spyOn to predef in .jshint.json to tell Hound not to comment on this.

This comment has been minimized.

Copy link
@svbergerem

svbergerem Feb 14, 2015

Author Member

Thanks! Already did this 2 hours ago in the next commit. ;-)

This comment has been minimized.

Copy link
@salbertson
@ghost

This comment has been minimized.

Copy link

commented Feb 14, 2015

Cool ! Thank you for dealing with that.

@jhass jhass added this to the next-major milestone Feb 14, 2015

@jhass

This comment has been minimized.

Copy link
Member

commented Feb 14, 2015

Thank you!

@jhass jhass merged commit c5468f0 into diaspora:develop Feb 14, 2015

2 checks passed

continuous-integration/travis-ci The Travis CI build passed
Details
hound Hound has reviewed the changes.

jhass added a commit that referenced this pull request Feb 14, 2015

@svbergerem svbergerem deleted the svbergerem:help-section-routing branch Feb 14, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.