Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrap stream: add spinner and improve comment box #5672

Merged
merged 2 commits into from Feb 16, 2015

Conversation

@svbergerem
Copy link
Member

commented Feb 16, 2015

This fixes two issues mentioned in #5247. It adds the ajax-spinner to the stream and improves the comment box. The height of the comment box is now set to 30px (just like in the blueprint stream) and only expands when someone enters some text that is too big. (done by js like for the blueprint stream) The submit button will be hidden unless the comment box is focused or there is some text in the comment box.

Steffen van Bergerem added some commits Feb 16, 2015

@svbergerem

This comment has been minimized.

Copy link
Member Author

commented Feb 16, 2015

The last commit also fixed the report and block buttons for Bootstrap streams.

@jhass jhass added this to the next-major milestone Feb 16, 2015

jhass added a commit that referenced this pull request Feb 16, 2015

Merge pull request #5672 from svbergerem/bootstrap-stream-improvements
Bootstrap stream: add spinner and improve comment box

@jhass jhass merged commit 3149ab7 into diaspora:develop Feb 16, 2015

2 checks passed

continuous-integration/travis-ci The Travis CI build passed
Details
hound Hound has reviewed the changes.
@jhass

This comment has been minimized.

Copy link
Member

commented Feb 16, 2015

Thank you!

@svbergerem svbergerem deleted the svbergerem:bootstrap-stream-improvements branch Feb 16, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.