Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix code overflow in mobile comments #5586 #5675

Merged

Conversation

@SansPseudoFix
Copy link
Contributor

commented Feb 16, 2015

Fix for code overflow in mobile view comments (issue #5586).
Tested for Firefox Android 4.4 :
screenshot_overflow_mobile_comments

SpF, your overflow specialist since 3 PR.

@goobertron

This comment has been minimized.

Copy link

commented Feb 16, 2015

SpF, your overflow specialist since 3 PR.

:-)

@svbergerem

This comment has been minimized.

Copy link
Member

commented Feb 17, 2015

@SansPseudoFix Thank you. While testing your code I found out that we have the problem not only for comments but also for posts on the mobile website. It would be great if you could also fix that.

svbergerem pushed a commit to svbergerem/diaspora that referenced this pull request Feb 17, 2015

Steffen van Bergerem
Merge pull request diaspora#5675 from SansPseudoFix/5586-fix-overflow…
…-code-mobile

fix code overflow in mobile comments diaspora#5586
@SansPseudoFix

This comment has been minimized.

Copy link
Contributor Author

commented Feb 17, 2015

Oh ?! My post for this test was a code block too, and I didn't notice this problem. I'll check today, and fix it if I see it.

@SansPseudoFix

This comment has been minimized.

Copy link
Contributor Author

commented Feb 17, 2015

Okay, get it. Bug appears for inline code.

@SansPseudoFix

This comment has been minimized.

Copy link
Contributor Author

commented Feb 17, 2015

As usual, I have some troubles with rebase. I'm working on it :)

@SansPseudoFix SansPseudoFix force-pushed the SansPseudoFix:5586-fix-overflow-code-mobile branch from ff59879 to 0c49219 Feb 17, 2015

@SansPseudoFix

This comment has been minimized.

Copy link
Contributor Author

commented Feb 17, 2015

Done :)

@svbergerem svbergerem merged commit 0c49219 into diaspora:develop Feb 17, 2015

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
hound Hound has reviewed the changes.

svbergerem pushed a commit that referenced this pull request Feb 17, 2015

Steffen van Bergerem
Merge pull request #5675 from SansPseudoFix/5586-fix-overflow-code-mo…
…bile

fix code overflow in mobile comments #5586

@svbergerem svbergerem added this to the next-major milestone Feb 17, 2015

@svbergerem

This comment has been minimized.

Copy link
Member

commented Feb 17, 2015

Thanks! :)

@SansPseudoFix SansPseudoFix deleted the SansPseudoFix:5586-fix-overflow-code-mobile branch Nov 10, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.