New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to pod statistics in right navigation #6117

Closed
wants to merge 1 commit into
base: develop
from

Conversation

Projects
None yet
3 participants
@SansPseudoFix
Copy link
Contributor

SansPseudoFix commented Jun 18, 2015

Result:

link_for_stat

@svbergerem svbergerem added this to the 0.5.2.0 milestone Jun 18, 2015

@@ -2,6 +2,7 @@
%li= link_to 'wiki', "https://wiki.diasporafoundation.org"
%li= link_to t('layouts.application.whats_new'), changelog_url
%li= link_to t('layouts.header.code') + " " + pod_version, "#{source_url}", {:title => t('layouts.application.source_package')}
%li= link_to t('layouts.application.statistics_link'), statistics_path

This comment has been minimized.

@svbergerem

svbergerem Jun 18, 2015

Member

please use doublequotes

This comment has been minimized.

@SansPseudoFix

SansPseudoFix Jun 19, 2015

Contributor

Okay. Do I do the same for other lines, or just mine?

This comment has been minimized.

@svbergerem

svbergerem Jun 19, 2015

Member

Just change the lines you already changed.

@goobertron

This comment has been minimized.

Copy link

goobertron commented Jun 19, 2015

Good idea. What would you think about using 'Network statistics' as the label, to make it more clear what these statistics are?

@SansPseudoFix

This comment has been minimized.

Copy link
Contributor

SansPseudoFix commented Jun 19, 2015

Yes, I didn't know which word to use, so I just used "Statistics". To be more specific, I can use "Pod statistics" maybe ("Network statistics" can be confused -> all diaspora* network).

@goobertron

This comment has been minimized.

Copy link

goobertron commented Jun 19, 2015

Oh, I'm sorry. Without checking the code, I assumed this was a link to the network statistics page (http://the-federation.info/). If it is to the pod's own statistics page, then yes, 'Pod statistics' would be appropriate. I suppose this proves that 'Statistics' alone would be confusing!

@goobertron

This comment has been minimized.

Copy link

goobertron commented Jun 19, 2015

(And now I noticed that your PR has 'pod statistics' in its title - time for another eye test...)

@SansPseudoFix

This comment has been minimized.

Copy link
Contributor

SansPseudoFix commented Jun 19, 2015

:D
But you're right, "Statistics" only is confusing. I will change that for "Pod statistics".

Add link to pod statistics in right navigation
Add link to pod statistics in right navigation

	modifié :         app/views/shared/_links.haml
	modifié :         config/locales/diaspora/en.yml

Add pod statistics link

@SansPseudoFix SansPseudoFix force-pushed the SansPseudoFix:add-statistics-link branch from 38e023f to 2f326dc Jun 19, 2015

@SansPseudoFix

This comment has been minimized.

Copy link
Contributor

SansPseudoFix commented Jun 19, 2015

Done.

@svbergerem

This comment has been minimized.

Copy link
Member

svbergerem commented Jun 19, 2015

Thank you.

@SansPseudoFix SansPseudoFix deleted the SansPseudoFix:add-statistics-link branch Nov 10, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment