New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactorings from #6151 #6168

Closed
wants to merge 5 commits into
base: develop
from

Conversation

Projects
None yet
3 participants
@SuperTux88
Copy link
Member

SuperTux88 commented Jul 5, 2015

This PR contains the refactorings from #6151 that are not directly related to the federation-gem:

  • refactored the atom_url to contain the .atom suffix
  • removed unused publics_helper, this was unused since 2010
  • don't get person.url from the hcard, this is already set from the webfinger
  • add a url_to helper method to generate the urls

I want these commits out of the other PR :)

@username ||= owner ? owner.username : diaspora_handle.split("@")[0]
end


This comment has been minimized.

@houndci-bot

houndci-bot Jul 5, 2015

Extra blank line detected.

SuperTux88 added some commits Jun 28, 2015

remove unused publics_helper
the Subscriber stuff was removed in 2010:
f97218c
fix rubocop warnings in poor_mans_webmock.rb
and remove unused HttpPost mock

@SuperTux88 SuperTux88 force-pushed the SuperTux88:federation-gem-preparation branch from e8bb740 to 77e9c5f Jul 5, 2015

@jhass jhass modified the milestones: 0.6.0.0, 0.5.2.0 Jul 5, 2015

@jhass jhass closed this in b0a9a63 Jul 5, 2015

@jhass

This comment has been minimized.

Copy link
Member

jhass commented Jul 5, 2015

Merged as b0a9a63 97f973b f45e053 540b8df 2294e59

Thanks!

@SuperTux88 SuperTux88 deleted the SuperTux88:federation-gem-preparation branch Aug 9, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment