Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace jquery.autocomplete with typeahead.js #6293

Merged
merged 2 commits into from Aug 12, 2015

Conversation

@svbergerem
Copy link
Member

commented Aug 4, 2015

Some tests are still missing. This PR replaces jquery.autocomplete with typeahead.js and adds contacts to the search suggestions, even if they aren't searchable. (#4789) This PR doesn't add those contacts to the search page itself.

@svbergerem svbergerem added this to the 0.6.0.0 milestone Aug 4, 2015

@ghost

This comment has been minimized.

Copy link

commented Aug 4, 2015

Nice! Thanks for doing this \o/
Do you think you could also add contacts suggestion on mobile view?

@svbergerem svbergerem force-pushed the svbergerem:typeahead branch from 98d0867 to 1e82360 Aug 7, 2015

@ghost ghost referenced this pull request Aug 8, 2015
1 of 4 tasks complete

@svbergerem svbergerem force-pushed the svbergerem:typeahead branch from 1e82360 to ce17820 Aug 10, 2015

@svbergerem svbergerem changed the title [WIP] Replace jquery.autocomplete with typeahead.js Replace jquery.autocomplete with typeahead.js Aug 10, 2015

Steffen van Bergerem added 2 commits Aug 1, 2015

@svbergerem svbergerem force-pushed the svbergerem:typeahead branch from ce17820 to e8acaa0 Aug 10, 2015

@svbergerem

This comment has been minimized.

Copy link
Member Author

commented Aug 10, 2015

This PR should be ready to review.

@jhass

This comment has been minimized.

Copy link
Member

commented Aug 12, 2015

Thank you!

@jhass jhass merged commit e8acaa0 into diaspora:develop Aug 12, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
jhass added a commit that referenced this pull request Aug 12, 2015
Merge pull request #6293 from svbergerem/typeahead
Replace jquery.autocomplete with typeahead.js
@ghost

This comment has been minimized.

Copy link

commented Aug 12, 2015

Can't autoSuggest.js be replaced too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.