Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not add participation for comment if comment validation failed #6552

Conversation

@manuelVo
Copy link
Contributor

commented Nov 18, 2015

Previously the server created a participation for a comment before validating the comment itself. Thus if a client sent an invalid comment to the server (e.g. consists only of spaces) a participation would be created while the comment was refused. This pull request changes the order of the operations so that comment is validated before the participation gets created.

I also noticed that the other social actions had the same odd behavior so i changed them too.

The same fix is also done for the other social actions
@jhass jhass added this to the 0.5.5.0 milestone Nov 18, 2015
@jhass jhass closed this in 0925a26 Nov 18, 2015
@jhass

This comment has been minimized.

Copy link
Member

commented Nov 18, 2015

Merged as 0925a26

Good catch, thank you!

@Flaburgan

This comment has been minimized.

Copy link
Member

commented Nov 18, 2015

Thank you!

@manuelVo manuelVo deleted the manuelVo:dont-participate-on-invalid-comment branch Jan 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.