Dark theme #7152

Closed
wants to merge 2 commits into
from

Projects

None yet

5 participants

@SuperTux88
Member

I created a dark theme for diaspora:

diaspora-dark

(If you have an account on nerdpol.ch you can also test it there.)

I also refactored the default theme a bit, to use more color-variables and less overrides (makes diaspora better themeable if you want to change more than the header color). And I renamed the default theme to "Original Gray" instead of "Original Dark" because I found it weird, because the default theme isn't "dark" (only the header is dark).

@AugierLe42e
Contributor

Wow... That's... Really dark !

@goobertron
Contributor

I think 'Default' might be a better name instead of 'Original [Dark/Gray]'. What do others think?

ps: you should make the text and images black as well for a really dark theme...

@SuperTux88
Member

Wow... That's... Really dark !

Yes, thats the intention of a dark theme ;)

I think 'Default' might be a better name instead of 'Original [Dark/Gray]'. What do others think?

I don't know. Podmins can set another default-theme and I think "Default" as name can be weird then?

ps: you should make the text and images black as well for a really dark theme...

No, I think it's dark enough ;)

@AugierLe42e
Contributor

Yes, thats the intention of a dark theme ;)

Sad. I would really love to have a dark gray theme. But this one misses some contrast for me :(

@SuperTux88
Member

I made the backgrounds a bit darker and the text-color lighter, so it have more contrast now.

screen shot 2016-11-05 at 19 46 16

I also updated nerdpol.ch with the new theme.

@@ -176,7 +176,7 @@ footer {
border-radius: 3px 3px 0 0;
border: {
- bottom: 1px solid #ccc;
+ bottom: 1px solid $border-medium-grey;
@denschub
denschub Nov 5, 2016 Member

When you are already changing and adding variables... can we try to get a more generic naming? This border may not be grey and I'd rather have a generic name for the variables. Also, we should find a consent between grey and gray, I guess...

@SuperTux88
SuperTux88 Nov 5, 2016 Member

$border-medium-grey existed before, I'm only using it instead of the hardcoded color.

But I agree with you about the naming. I tried to use better names for new variables I created, but I didn't rename existing variables. I didn't want to change too much here, the PR is already big enough. I only used the existing variables instead of hardcoded colors, so I need less css-hacks here. I think the renaming should be done in another PR?

@denschub
denschub Nov 5, 2016 Member

I think the renaming should be done in another PR?

Well. This probably means it will never be done, but fair point. Okay. :)

@SuperTux88
SuperTux88 Nov 5, 2016 Member

I love cleanups, so I'll do it sometime (if nobody else does it), but I'd rather not do it now as drive-by for a theme. ;)

@denschub
Member
denschub commented Nov 5, 2016

This is nice.

@SuperTux88 SuperTux88 Add dark theme
Also renamed "Original Dark" to "Original Gray", because it isn't "dark".
9b82ac3
+ .ball { filter: invert(100%); }
+ }
+
+ .spinner { border-color: $gray-light transparent $gray-light $gray-light; }
@diaspora-code-review
diaspora-code-review Nov 6, 2016

Shorthands of length 4 are not allowed. Value was $gray-light transparent $gray-light $gray-light

@denschub denschub added a commit that closed this pull request Nov 6, 2016
@SuperTux88 @denschub SuperTux88 + denschub Add dark theme
Also renamed "Original Dark" to "Original Gray", because it isn't "dark".

closes #7152
08282ce
@denschub denschub closed this in 08282ce Nov 6, 2016
@denschub
Member
denschub commented Nov 6, 2016

Sweet stuff, merged. Thank you!

@denschub denschub added this to the 0.6.2.0 milestone Nov 6, 2016
@SuperTux88 SuperTux88 deleted the SuperTux88:dark-theme branch Nov 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment