Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API #8086

Merged
merged 161 commits into from Jan 22, 2020
Merged

API #8086

merged 161 commits into from Jan 22, 2020

Conversation

@jhass
Copy link
Member

jhass commented Jan 21, 2020

"Rebased" version of #7462 to clear out any !fixup's

KentShikama and others added 30 commits Aug 9, 2015
* For record not found returns a 404 response
* For wrong parameters returns a 400 response
* For other exceptions returns a 500 response
Including messages and visibilities
* Comments
* Likes
* Streams
* Base the API requesting on GUID instead of ID
* Include read field
* Do not include messages in conversation results
Put streams under the subpath `/streams`.
* Fix active record not found case
* Display backtrace in error logs
@jhass

This comment has been minimized.

Copy link
Member Author

jhass commented Jan 21, 2020

So this has an extra commit to undo some merge conflict hassle vs the original PR has some !fixups not being rebased out. Pick whatever you find cleaner :)

@denschub denschub mentioned this pull request Jan 21, 2020
@jhass jhass added this to the 0.8.0.0 milestone Jan 22, 2020
@denschub denschub merged commit 8d690a9 into diaspora:develop Jan 22, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+17.6%) to 94.78%
Details
denschub added a commit that referenced this pull request Jan 22, 2020
API
@jhass

This comment has been minimized.

Copy link
Member Author

jhass commented Jan 22, 2020

💖

@jhass jhass deleted the jhass:api branch Jan 22, 2020
@denschub

This comment has been minimized.

Copy link
Member

denschub commented Jan 22, 2020

🎉

Thanks to everyone who worked on this project, past and present. This is huge. :)

@Flaburgan

This comment has been minimized.

Copy link
Member

Flaburgan commented Jan 22, 2020

Thanks to everybody involved here, and special thanks to @KentShikama, @frankrousseau and @HankG who did an awesome job!

@HankG

This comment has been minimized.

Copy link
Contributor

HankG commented Jan 22, 2020

Very exciting news! Thanks to the whole team who helped bring this to fruition!

@frankrousseau

This comment has been minimized.

Copy link
Contributor

frankrousseau commented Jan 22, 2020

It almost sounds like a miracle! I hope it will bring a lot of new capabilities to the Diaspora project.
Thank you for the review, the rebase and the merge!

@DeadSuperHero

This comment has been minimized.

Copy link
Member

DeadSuperHero commented Jan 23, 2020

Wow, this is incredible! Congrats on finally getting this merged.

@wiegelmann

This comment has been minimized.

Copy link

wiegelmann commented Jan 23, 2020

Dreams come true. Many thanks!

@SuperTux88 SuperTux88 added the api label Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

10 participants
You can’t perform that action at this time.