Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upPreliminary Haiku support #94
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Nice Icon, but would it be possible to put it in a folder so that the name and intend is clear? Probably not many are familiar with .rdef.in files and as we start to support more platforms this could clutter the root. |
This comment has been minimized.
This comment has been minimized.
|
Yeah, we can do that. |
This comment has been minimized.
This comment has been minimized.
|
I was thinking resources/$osname |
| @@ -21,6 +21,14 @@ | |||
| #ifdef _MSC_VER | |||
| #pragma comment(lib, "wininet.lib") // Internet functions for HTTP stream | |||
| #pragma warning(disable: 4800) // 'BOOL' : forcing value to bool 'true' or 'false' (performance warning) | |||
| #endif | |||
|
|
|||
| #ifdef __HAIKU__ | |||
This comment has been minimized.
This comment has been minimized.
AJenbo
Apr 30, 2019
Member
It looks like stormlib solved the same issue for FreeBSD by settings this in CMake:
https://github.com/ladislav-zezula/StormLib/blob/master/CMakeLists.txt#L303
I think we should go for the same solution here instead of modifying the stormlib source localy.
This comment has been minimized.
This comment has been minimized.
AJenbo
Apr 30, 2019
Member
O_LARGEFILE should be disabled in StormPort.h
https://github.com/ladislav-zezula/StormLib/blob/4ad0bff21da0163917e1552960e6a43679586b89/src/StormPort.h#L202
It looks like this is also the place to define *64 functions, not sure why they ended up putting it in CMake for FreeBSD :/
This comment has been minimized.
This comment has been minimized.
|
Nice work upstreaming the storm changes. Should the aiso changes also be upstreamed? |
This comment has been minimized.
This comment has been minimized.
|
@AJenbo : i tried to upstream the asio patches, but i had to see it is already done and merged. The devilution in-tree version is just too old. |
This comment has been minimized.
This comment has been minimized.
|
Good to know Again thanks for the PR |

extrowerk commentedApr 29, 2019
With these patches it builds and works on Haiku (tested only on 64 bit with GCC7):