Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add_hash_with_abundance method in core library #890

Closed
luizirber opened this issue Feb 6, 2020 · 0 comments · Fixed by #892
Closed

add_hash_with_abundance method in core library #890

luizirber opened this issue Feb 6, 2020 · 0 comments · Fixed by #892
Labels

Comments

@luizirber
Copy link
Member

@luizirber luizirber commented Feb 6, 2020

From #887 (comment):

It would be nice to have a add_hash_with_abundance and avoid the add_many behavior (calling add_hash in a loop), but that can be done later.

Also want to avoid copy and pasting code. Maybe move the implementation of add_hash into add_hash_with_abundance, and replace add_hash implementation with add_hash_with_abundance(h, 1)?

@luizirber luizirber added the rust label Feb 6, 2020
luizirber added a commit that referenced this issue Feb 6, 2020
@luizirber luizirber mentioned this issue Feb 6, 2020
5 of 5 tasks complete
luizirber added a commit that referenced this issue Feb 7, 2020
@ctb ctb closed this in #892 Feb 8, 2020
ctb pushed a commit that referenced this issue Feb 8, 2020
* fixes #890

* hypothesis tests

* set up hypothesis

* skip all other tests if --run-hypothesis is set

* properly check abundances
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

1 participant
You can’t perform that action at this time.