New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] Fix Jaccard calculation to be intersection over union #150
Conversation
@luizirber I ran headlong into Cython issues related to calling |
@luizirber all tests fixed. Review pls? |
Codecov Report
@@ Coverage Diff @@
## master #150 +/- ##
==========================================
- Coverage 85.52% 85.31% -0.22%
==========================================
Files 13 13
Lines 1879 1879
Branches 52 52
==========================================
- Hits 1607 1603 -4
- Misses 263 265 +2
- Partials 9 11 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. We shouldn't need to change the merge
to merge_abund
, but it's not a problem that needs fixing in this PR.
Fixes #125 so that we are MinHash-correct by computing Jaccard estimator as intersection over union of k-mers. This makes it symmetric & presumably mash compatible but also breaks many tests :)
make test
Did it pass the tests?make coverage
Is the new code covered?without a major version increment. Changing file formats also requires a
major version number increment.
changes were made?
TODO: