Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sequence Bloom Tree-based search into sourmash #45

Merged
merged 77 commits into from Dec 29, 2016
Merged

Add Sequence Bloom Tree-based search into sourmash #45

merged 77 commits into from Dec 29, 2016

Conversation

@ctb
Copy link
Member

ctb commented Nov 10, 2016

Makes use of @luizirber code from https://github.com/luizirber/2016-sbt-minhash to provid indexing and search subcommands.

Interesting question to ask: should we copy the SBT files into this repo? We could either have the SBT stuff be another project or we could develop it as part of sourmash until we have reason to split it off. Alternatively we could develop the SBT code as part of khmer (again, until we have reason to split).

  • Is it mergeable?
  • make test Did it pass the tests?
  • make coverage Is the new code covered?
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Was a spellchecker run on the source code and documentation after
    changes were made?
@ctb
Copy link
Member Author

ctb commented Nov 18, 2016

The lazy loading hack (5a78330) really speeds things up @luizirber!

@codecov-io
Copy link

codecov-io commented Dec 1, 2016

Current coverage is 72.92% (diff: 58.03%)

Merging #45 into master will decrease coverage by 10.34%

@@             master        #45   diff @@
==========================================
  Files             9         11     +2   
  Lines          1106       1869   +763   
  Methods          38         38          
  Messages          0          0          
  Branches         48         48          
==========================================
+ Hits            921       1363   +442   
- Misses          167        488   +321   
  Partials         18         18          

Powered by Codecov. Last update fa02e9e...2269262

@luizirber
Copy link
Member

luizirber commented Dec 29, 2016

Needs some tests for categorize and search, but I'm merging because we are putting too much stuff on this already!

@luizirber luizirber merged commit f93f56a into master Dec 29, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@luizirber luizirber added the sbt label May 4, 2017
@luizirber luizirber deleted the sbt_search branch May 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.