New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --ignore-abundance to "search" and "categorize" #543

Merged
merged 8 commits into from Sep 17, 2018

Conversation

Projects
None yet
2 participants
@olgabot
Copy link
Contributor

olgabot commented Sep 14, 2018

Addresses #541

  • Is it mergeable?
  • make test Did it pass the tests?
  • make coverage Is the new code covered?
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Was a spellchecker run on the source code and documentation after
    changes were made?
@olgabot

This comment has been minimized.

Copy link
Contributor Author

olgabot commented Sep 14, 2018

For some reason sourmash categorize with and without --ignore-abundance produce the same results when using the gather-abund dataset and I can't figure out why 😭

@olgabot

This comment has been minimized.

Copy link
Contributor Author

olgabot commented Sep 17, 2018

Yay passing tests!! Since this changes the CLI, should this PR also bump a version?

@luizirber

This comment has been minimized.

Copy link
Member

luizirber commented Sep 17, 2018

We need to bump the version, but we also need to stop with the a9 scheme and accept that sourmash 2.0 is official at this point =]

@luizirber luizirber merged commit c202750 into dib-lab:master Sep 17, 2018

4 checks passed

WIP ready for review
Details
codecov/patch 100% of diff hit (target 90.76%)
Details
codecov/project 90.78% (+0.02%) compared to 3ffac2d
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@luizirber

This comment has been minimized.

Copy link
Member

luizirber commented Sep 17, 2018

Thanks @olgabot !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment