New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Make sure either scaled or num is set on `MinHash(...)` construction #605

Merged
merged 2 commits into from Jan 7, 2019

Conversation

Projects
None yet
2 participants
@ctb
Copy link
Member

ctb commented Jan 7, 2019

thx @halexand for finding the bug :)

  • Is it mergeable?
  • make test Did it pass the tests?
  • make coverage Is the new code covered?
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Was a spellchecker run on the source code and documentation after
    changes were made?
@codecov

This comment has been minimized.

Copy link

codecov bot commented Jan 7, 2019

Codecov Report

Merging #605 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #605   +/-   ##
=======================================
  Coverage   88.64%   88.64%           
=======================================
  Files          25       25           
  Lines        3786     3786           
  Branches       37       37           
=======================================
  Hits         3356     3356           
  Misses        430      430

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef626e7...12da50d. Read the comment docs.

@luizirber luizirber merged commit 7f00dfe into master Jan 7, 2019

2 checks passed

codecov/patch Coverage not affected when comparing ef626e7...12da50d
Details
codecov/project 88.64% remains the same compared to ef626e7
Details

@luizirber luizirber deleted the fix/no_scaled_or_num branch Jan 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment