New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] add citation output #617

Merged
merged 8 commits into from Jan 11, 2019

Conversation

Projects
None yet
2 participants
@ctb
Copy link
Member

ctb commented Jan 10, 2019

Per #259. #478 is probably a better solution, but this is complementary?

  • Is it mergeable?
  • make test Did it pass the tests?
  • make coverage Is the new code covered?
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Was a spellchecker run on the source code and documentation after
    changes were made?
@ctb

This comment has been minimized.

Copy link
Member

ctb commented Jan 10, 2019

@luizirber your thoughts welcome on this approach. All that is left to do for 2.0.0, I think, is to replace all of the end-point ArgumentParser objects with the new class.

@codecov

This comment has been minimized.

Copy link

codecov bot commented Jan 10, 2019

Codecov Report

Merging #617 into master will increase coverage by 0.06%.
The diff coverage is 98.24%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #617      +/-   ##
==========================================
+ Coverage   89.38%   89.44%   +0.06%     
==========================================
  Files          27       27              
  Lines        4203     4227      +24     
  Branches       39       39              
==========================================
+ Hits         3757     3781      +24     
  Misses        446      446
Impacted Files Coverage Δ
sourmash/__main__.py 96% <ø> (ø) ⬆️
sourmash/lca/command_index.py 90.74% <100%> (+0.04%) ⬆️
sourmash/lca/command_compare_csv.py 93.58% <100%> (+0.08%) ⬆️
sourmash/lca/command_summarize.py 82.79% <100%> (+0.18%) ⬆️
sourmash/lca/command_gather.py 84.84% <100%> (+0.09%) ⬆️
sourmash/lca/command_classify.py 86.51% <100%> (+0.15%) ⬆️
sourmash/sourmash_args.py 95.96% <100%> (+0.33%) ⬆️
sourmash/sig/__main__.py 94.78% <100%> (ø) ⬆️
sourmash/lca/command_rankinfo.py 91.83% <100%> (+0.17%) ⬆️
sourmash/commands.py 89.09% <93.75%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64b3017...57f893e. Read the comment docs.

@luizirber

This comment has been minimized.

Copy link
Member

luizirber commented Jan 10, 2019

I like it. #478 is more general, but for now it is more complicated to implement and I don't want to see it blocking 2.0

Show resolved Hide resolved CITATION.cff

luizirber and others added some commits Jan 10, 2019

Update CITATION.cff with author info
Co-Authored-By: ctb <titus@idyll.org>

@ctb ctb changed the title [WIP] add citation output [MRG] add citation output Jan 11, 2019

@ctb

This comment has been minimized.

Copy link
Member

ctb commented Jan 11, 2019

Ready for review @luizirber

@luizirber luizirber merged commit ceb9b17 into master Jan 11, 2019

2 checks passed

codecov/patch 98.24% of diff hit (target 89.38%)
Details
codecov/project 89.44% (+0.06%) compared to 64b3017
Details

@luizirber luizirber deleted the add/argparse_citation branch Jan 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment