Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] release notes for v2.0 #630

Merged
merged 10 commits into from Mar 9, 2019

Conversation

Projects
None yet
2 participants
@ctb
Copy link
Member

ctb commented Jan 13, 2019

Fixes #623.

See rendered release notes

  • Is it mergeable?
  • make test Did it pass the tests?
  • make coverage Is the new code covered?
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Was a spellchecker run on the source code and documentation after
    changes were made?
@codecov

This comment has been minimized.

Copy link

codecov bot commented Jan 13, 2019

Codecov Report

Merging #630 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #630   +/-   ##
=======================================
  Coverage   89.47%   89.47%           
=======================================
  Files          27       27           
  Lines        4238     4238           
  Branches       39       39           
=======================================
  Hits         3792     3792           
  Misses        446      446

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8797eb6...73cbff9. Read the comment docs.

@ctb

This comment has been minimized.

Copy link
Member Author

ctb commented Jan 13, 2019

Wondering if this should be part of #592, or maybe a new "actually release 2.0 now" PR?

ctb added some commits Jan 13, 2019

@ctb ctb changed the title [WIP] first draft release notes for v2.0 [MRG] release notes for v2.0 Feb 23, 2019

@ctb

This comment has been minimized.

Copy link
Member Author

ctb commented Feb 23, 2019

Ready for review (but not merge).

@ctb

This comment has been minimized.

Copy link
Member Author

ctb commented Mar 7, 2019

Hey @luizirber I think this is the last one that needs your attention before I can work more on the release.

luizirber added some commits Mar 7, 2019

@luizirber

This comment has been minimized.

Copy link
Member

luizirber commented Mar 7, 2019

I brought in two changes:

  • fix travis wheel build
  • remove tests and benchmarks from the published pypi package, as well as test data (per #600). The dev instructions were already failing (I noticed this in #554). But fixing the "run tests from installed package" will require more work (punt to a 2.x patch?)

@ctb ctb merged commit 38595be into master Mar 9, 2019

2 checks passed

codecov/patch Coverage not affected when comparing 8797eb6...73cbff9
Details
codecov/project 89.47% remains the same compared to 8797eb6
Details

@luizirber luizirber deleted the add/release_notes branch Mar 14, 2019

luizirber added a commit that referenced this pull request Mar 19, 2019

[MRG] release notes for v2.0 (#630)
* first draft release notes for v2.0

* title it

* update more

* fix link

* travis build fix

* don't include tests and benchmarks

* more travis fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.