Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory leak in `MinHash.intersection`. #687

Merged
merged 1 commit into from Jun 6, 2019
Merged
Changes from all commits
Commits
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.

Always

Just for now

Fix memory leak in `MinHash.intersection`.

The intersection function uses the `new` operator to construct
a `KmerMinHash` or `KmerMinAbundance`. Although this is Cython,
`new` still heap-allocates the object, and it is *not* marked
for garbage collection, because it isn't a PyObject. This commit
calls delete (`del`) on the allocated object to prevent it from
being leaked.
  • Loading branch information...
camillescott committed Jun 6, 2019
commit 3c8c54e9b9612e8c1514a8d5c8a831badd8e4206
@@ -324,7 +324,10 @@ cdef class MinHash(object):
common.intersection_update(other.get_mins())
common.intersection_update(combined_mh.mins)

return common, max(combined_mh.size(), 1)
size = max(combined_mh.size(), 1)
del combined_mh

return common, size

def compare(self, MinHash other):
common, size = self.intersection(other)
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.