Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exception assertions #693

Merged
merged 1 commit into from Jul 6, 2019

Conversation

Projects
None yet
2 participants
@luizirber
Copy link
Member

commented Jul 6, 2019

Master branch is broken because pytest 5 changed how to check for exception messages. This PR fixes the checks.

  • Is it mergeable?
  • make test Did it pass the tests?
  • make coverage Is the new code covered?
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Was a spellchecker run on the source code and documentation after
    changes were made?
@codecov

This comment has been minimized.

Copy link

commented Jul 6, 2019

Codecov Report

Merging #693 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #693   +/-   ##
=======================================
  Coverage   89.26%   89.26%           
=======================================
  Files          27       27           
  Lines        4238     4238           
  Branches       39       39           
=======================================
  Hits         3783     3783           
  Misses        455      455

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bd362f...a6dcdb1. Read the comment docs.

@luizirber

This comment has been minimized.

Copy link
Member Author

commented Jul 6, 2019

Ready for review and merge @ctb @olgabot

@ctb

ctb approved these changes Jul 6, 2019

Copy link
Member

left a comment

LGTM

@ctb ctb merged commit 534d269 into master Jul 6, 2019

3 checks passed

Travis CI - Pull Request Build Passed
Details
codecov/patch Coverage not affected when comparing 6bd362f...a6dcdb1
Details
codecov/project 89.26% remains the same compared to 6bd362f
Details

@ctb ctb deleted the fix/pytest5 branch Jul 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.