Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Fix --output-unassigned to output abundances if available. #726

Merged
merged 3 commits into from Sep 8, 2019

Conversation

@ctb
Copy link
Member

commented Sep 7, 2019

Fixes #705.

  • Is it mergeable?
  • make test Did it pass the tests?
  • make coverage Is the new code covered?
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Was a spellchecker run on the source code and documentation after
    changes were made?

@ctb ctb changed the title Fix --output-unassigned to output abundances if available. [MRG] Fix --output-unassigned to output abundances if available. Sep 7, 2019

@codecov

This comment has been minimized.

Copy link

commented Sep 7, 2019

Codecov Report

Merging #726 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #726      +/-   ##
==========================================
+ Coverage   89.27%   89.28%   +<.01%     
==========================================
  Files          29       29              
  Lines        4374     4378       +4     
  Branches       45       45              
==========================================
+ Hits         3905     3909       +4     
  Misses        467      467              
  Partials        2        2
Impacted Files Coverage Δ
sourmash/commands.py 88.77% <100%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bbc1f5...1b0da62. Read the comment docs.

@ctb

This comment has been minimized.

Copy link
Member Author

commented Sep 7, 2019

Ready for review & merge @luizirber @taylorreiter @bluegenes @olgabot

@ctb ctb merged commit 411c9fd into master Sep 8, 2019

3 checks passed

Travis CI - Pull Request Build Passed
Details
codecov/patch 100% of diff hit (target 89.27%)
Details
codecov/project 89.28% (+<.01%) compared to 5bbc1f5
Details

@ctb ctb deleted the fix/output_unassigned_with_abund branch Sep 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.