Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Update docstring for `--traverse-directory` on `sourmash index` #727

Merged
merged 1 commit into from Sep 8, 2019

Conversation

@ctb
Copy link
Member

commented Sep 7, 2019

Addresses #649.

  • Is it mergeable?
  • make test Did it pass the tests?
  • make coverage Is the new code covered?
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Was a spellchecker run on the source code and documentation after
    changes were made?

@ctb ctb changed the title Update docstring for `--traverse-directory` on `sourmash index` [MRG] Update docstring for `--traverse-directory` on `sourmash index` Sep 7, 2019

@codecov

This comment has been minimized.

Copy link

commented Sep 7, 2019

Codecov Report

Merging #727 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #727   +/-   ##
=======================================
  Coverage   89.27%   89.27%           
=======================================
  Files          29       29           
  Lines        4374     4374           
  Branches       45       45           
=======================================
  Hits         3905     3905           
  Misses        467      467           
  Partials        2        2
Impacted Files Coverage Δ
sourmash/commands.py 88.72% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 605b747...ebf67ad. Read the comment docs.

@ctb

This comment has been minimized.

Copy link
Member Author

commented Sep 7, 2019

Ready for review & merge @luizirber @taylorreiter @bluegenes @olgabot

@luizirber luizirber merged commit 5bbc1f5 into master Sep 8, 2019

3 checks passed

Travis CI - Pull Request Build Passed
Details
codecov/patch Coverage not affected when comparing 605b747...ebf67ad
Details
codecov/project 89.27% remains the same compared to 605b747
Details

@luizirber luizirber deleted the update/index_docstring branch Sep 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.