Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for WASI compilation #771

Merged
merged 2 commits into from Nov 7, 2019

Conversation

@luizirber
Copy link
Member

luizirber commented Nov 7, 2019

wasm32-unknown-unknown (the webassembly target for browsers) and wasm32-wasi both have the same target arch, so change the conditional compilation to account for that.

(also avoid a call to .canonicalize() because that's not implemented in WASI std yet...)

Checklist

  • Is it mergeable?
  • make test Did it pass the tests?
  • make coverage Is the new code covered?
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Was a spellchecker run on the source code and documentation after
    changes were made?
@luizirber luizirber added the rust label Nov 7, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 7, 2019

Codecov Report

Merging #771 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #771   +/-   ##
=======================================
  Coverage   89.48%   89.48%           
=======================================
  Files          29       29           
  Lines        4554     4554           
  Branches       46       46           
=======================================
  Hits         4075     4075           
  Misses        476      476           
  Partials        3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92c8bf9...482f6e4. Read the comment docs.

@luizirber luizirber merged commit 3d5adef into master Nov 7, 2019
8 checks passed
8 checks passed
build
Details
LGTM analysis: C/C++ No code changes detected
Details
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No code changes detected
Details
Travis CI - Pull Request Build Passed
Details
codecov/patch Coverage not affected when comparing 92c8bf9...482f6e4
Details
codecov/project 89.48% remains the same compared to 92c8bf9
Details
netlify/sourmash-docs/deploy-preview Deploy preview ready!
Details
@luizirber luizirber deleted the rust/wasi_test branch Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.