Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playing with MQF #772

Merged
merged 6 commits into from Nov 8, 2019

Conversation

@luizirber
Copy link
Member

luizirber commented Nov 7, 2019

This PR implements a new SBT using MQFs as internal nodes, based on the rust_ffi branch at the MQF repo.

(it was also driving what features to expose initially on the MQF wrapper).

Since there is no index building implemented in Rust yet, https://github.com/dib-lab/sourmash/compare/rust/mqf_sketch?expand=1#diff-7154331bd19ac9d7b71a5499ac5955a8 is building the internal nodes explicitly (and will serve as reference for when index building is actually implemented).

Checklist

  • Is it mergeable?
  • make test Did it pass the tests?
  • make coverage Is the new code covered?
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Was a spellchecker run on the source code and documentation after
    changes were made?
@luizirber luizirber added the rust label Nov 7, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 7, 2019

Codecov Report

Merging #772 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #772   +/-   ##
=======================================
  Coverage   89.48%   89.48%           
=======================================
  Files          29       29           
  Lines        4554     4554           
  Branches       46       46           
=======================================
  Hits         4075     4075           
  Misses        476      476           
  Partials        3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d5adef...b7eea2a. Read the comment docs.

@luizirber luizirber referenced this pull request Nov 7, 2019
3 of 5 tasks complete
@luizirber luizirber changed the title [WIP] Playing with MQF Playing with MQF Nov 8, 2019
@luizirber luizirber merged commit 542c6c8 into master Nov 8, 2019
8 checks passed
8 checks passed
build
Details
LGTM analysis: Python No code changes detected
Details
LGTM analysis: C/C++ No new or fixed alerts
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
Travis CI - Pull Request Build Passed
Details
codecov/patch Coverage not affected when comparing 3d5adef...b7eea2a
Details
codecov/project 89.48% remains the same compared to 3d5adef
Details
netlify/sourmash-docs/deploy-preview Deploy preview ready!
Details
@luizirber luizirber deleted the rust/mqf_sketch branch Nov 8, 2019
@ctb

This comment has been minimized.

Copy link
Member

ctb commented Nov 9, 2019

...are we bypassing reviews now, or is this a "doesn't actually affect sourmash functionality ATM" merge? :)

This comment has been minimized.

Copy link
Member Author

luizirber commented Nov 9, 2019 — with Octobox

I've been merging rust-only branches, do you want to review them?
(Anything touching Python/Cython/C++ goes thru review, of course)

@luizirber

This comment has been minimized.

Copy link
Member Author

luizirber commented Nov 9, 2019

I've also trying to bring down my branches/PR count, too much work on keeping everything in sync...

@luizirber luizirber referenced this pull request Nov 13, 2019
0 of 5 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.