Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix read the docs build #820

Merged
merged 3 commits into from Jan 4, 2020
Merged

Fix read the docs build #820

merged 3 commits into from Jan 4, 2020

Conversation

@luizirber
Copy link
Member

luizirber commented Jan 4, 2020

This PR uses the conda support to install Rust and fix the build errors in Read the Docs.

(Also add step 0 to release docs: check if docs are building before cutting a new release!)

Checklist

  • Is it mergeable?
  • make test Did it pass the tests?
  • make coverage Is the new code covered?
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Was a spellchecker run on the source code and documentation after
    changes were made?
@luizirber luizirber merged commit 6bcf1ee into master Jan 4, 2020
16 of 18 checks passed
16 of 18 checks passed
Check
Details
build
Details
test (beta)
Details
test (stable)
Details
test (windows) test (windows)
Details
test (macos)
Details
test_all_features
Details
coverage
Details
Lints
Details
Check if wasm-pack builds a valid package
Details
Run tests under wasm32-wasi Run tests under wasm32-wasi
Details
Publish (dry-run)
Details
minimum_rust_version
Details
Travis CI - Pull Request Build Errored
Details
netlify/sourmash-docs/deploy-preview Deploy preview processing.
Details
LGTM analysis: C/C++ No code changes detected
Details
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No code changes detected
Details
@luizirber luizirber deleted the fix_rtd_build branch Jan 4, 2020
@codecov

This comment has been minimized.

Copy link

codecov bot commented Jan 4, 2020

Codecov Report

Merging #820 into master will decrease coverage by 0.24%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #820      +/-   ##
==========================================
- Coverage    79.2%   78.95%   -0.25%     
==========================================
  Files          45       45              
  Lines        6702     6701       -1     
  Branches      470      470              
==========================================
- Hits         5308     5291      -17     
- Misses       1095     1111      +16     
  Partials      299      299
Flag Coverage Δ
#pytests 90.38% <ø> (ø) ⬆️
#rusttests 48.73% <ø> (ø) ⬆️
Impacted Files Coverage Δ
sourmash/_compat.py 50% <0%> (-50%) ⬇️
sourmash/signature_json.py 96.21% <0%> (-1.09%) ⬇️
sourmash/lca/lca_utils.py 96.22% <0%> (-0.63%) ⬇️
sourmash/lca/command_index.py 91.02% <0%> (-0.41%) ⬇️
sourmash/sbt.py 86.32% <0%> (-0.3%) ⬇️
sourmash/sbt_storage.py 86.66% <0%> (+0.95%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f800f3...cf02d7e. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.