Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] set up publishing workflow for NPM and crates.io #824

Merged
merged 2 commits into from Jan 6, 2020
Merged

Conversation

@luizirber
Copy link
Member

luizirber commented Jan 6, 2020

Set up GitHub Actions to publish the Rust crate to crates.io when there is a new tag. It also publishes the wasm-pack generated package (webassembly) to NPM.

I also started using r as the prefix for Rust releases, like r0.3.0. This doesn't conflict with the sourmash regular versioning (which starts with v, as in v3.0.0).

And... using r triggered an error for calculating the Python version 馃ぃ
So there is a fix to setuptools_scm to account only for v tags when calculating versions.

Checklist

  • Is it mergeable?
  • make test Did it pass the tests?
  • make coverage Is the new code covered?
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Was a spellchecker run on the source code and documentation after
    changes were made?
@luizirber luizirber added the rust label Jan 6, 2020
@codecov

This comment has been minimized.

Copy link

codecov bot commented Jan 6, 2020

Codecov Report

Merging #824 into master will increase coverage by 0.23%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #824      +/-   ##
==========================================
+ Coverage   78.94%   79.17%   +0.23%     
==========================================
  Files          45       45              
  Lines        6703     6705       +2     
  Branches      471      469       -2     
==========================================
+ Hits         5292     5309      +17     
+ Misses       1111     1096      -15     
  Partials      300      300
Flag Coverage 螖
#pytests 90.38% <酶> (酶) 猬嗭笍
#rusttests 48.71% <酶> (-0.03%) 猬囷笍
Impacted Files Coverage 螖
sourmash/sbt_storage.py 85.71% <0%> (-0.96%) 猬囷笍
src/core/src/lib.rs 52.19% <0%> (-0.29%) 猬囷笍
sourmash/sbt.py 86.61% <0%> (+0.29%) 猬嗭笍
sourmash/lca/command_index.py 91.42% <0%> (+0.4%) 猬嗭笍
sourmash/lca/lca_utils.py 96.85% <0%> (+0.62%) 猬嗭笍
sourmash/signature_json.py 97.29% <0%> (+1.08%) 猬嗭笍
sourmash/_compat.py 100% <0%> (+50%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 9c778e0...387555e. Read the comment docs.

@luizirber luizirber changed the title [WIP] set up publishing workflow for NPM and crates.io [MRG] set up publishing workflow for NPM and crates.io Jan 6, 2020
@luizirber

This comment has been minimized.

Copy link
Member Author

luizirber commented Jan 6, 2020

Ready for merge @ctb

Note: the setup.py must be merged really soon, so I can make another separate PR if there is more discussion in this one. Without the setup.py change all PRs will break because of the r0.3.0 tag.

(I can also delete it and retag later)

@ctb
ctb approved these changes Jan 6, 2020
@ctb ctb merged commit ddaae07 into master Jan 6, 2020
20 checks passed
20 checks passed
Check
Details
build
Details
test (beta)
Details
test (stable)
Details
test (windows)
Details
test (macos)
Details
test_all_features
Details
coverage
Details
Lints
Details
Check if wasm-pack builds a valid package for the sourmash crate
Details
Run tests under wasm32-wasi Run tests under wasm32-wasi
Details
Publish (dry-run)
Details
minimum_rust_version
Details
LGTM analysis: C/C++ No code changes detected
Details
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No new or fixed alerts
Details
Travis CI - Pull Request Build Passed
Details
codecov/patch Coverage not affected when comparing 9c778e0...387555e
Details
codecov/project 79.17% (+0.23%) compared to 9c778e0
Details
netlify/sourmash-docs/deploy-preview Deploy preview canceled.
Details
@luizirber luizirber deleted the rust_more_info branch Jan 7, 2020
@luizirber luizirber added this to the 3.1 milestone Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can鈥檛 perform that action at this time.