Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use python 3.7 in RTD build #825

Merged
merged 1 commit into from Jan 6, 2020
Merged

use python 3.7 in RTD build #825

merged 1 commit into from Jan 6, 2020

Conversation

@luizirber
Copy link
Member

luizirber commented Jan 6, 2020

I noticed the RTD build failed, and it was because Python 3.8 was being used. Since khmer (and many other projects) don't have 3.8 wheels yet, it goes over the time limit that RTD imposes (15 minutes) because it has to build everything from source.

Using 3.7 brings build time down to 403 seconds, which still leave enough time to avoid hitting the limit in the near future.

Checklist

  • Is it mergeable?
  • make test Did it pass the tests?
  • make coverage Is the new code covered?
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Was a spellchecker run on the source code and documentation after
    changes were made?
@luizirber

This comment has been minimized.

Copy link
Member Author

luizirber commented Jan 6, 2020

ready for review and merge @ctb

@ctb
ctb approved these changes Jan 6, 2020
@@ -3,3 +3,4 @@ channels:
- defaults
dependencies:
- rust
- python =3.7

This comment has been minimized.

Copy link
@ctb

ctb Jan 6, 2020

Member

does the single equals actually work!? cool.

This comment has been minimized.

Copy link
@luizirber

luizirber Jan 6, 2020

Author Member

One for conda, two for PyPI. Because... why be consistent? =P

@codecov

This comment has been minimized.

Copy link

codecov bot commented Jan 6, 2020

Codecov Report

Merging #825 into master will decrease coverage by 0.24%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #825      +/-   ##
==========================================
- Coverage   79.17%   78.93%   -0.25%     
==========================================
  Files          45       45              
  Lines        6705     6704       -1     
  Branches      469      469              
==========================================
- Hits         5309     5292      -17     
- Misses       1096     1112      +16     
  Partials      300      300
Flag Coverage Δ
#pytests 90.38% <ø> (ø) ⬆️
#rusttests 48.71% <ø> (ø) ⬆️
Impacted Files Coverage Δ
sourmash/_compat.py 50% <0%> (-50%) ⬇️
sourmash/signature_json.py 96.21% <0%> (-1.09%) ⬇️
sourmash/lca/lca_utils.py 96.22% <0%> (-0.63%) ⬇️
sourmash/lca/command_index.py 91.02% <0%> (-0.41%) ⬇️
sourmash/sbt.py 86.32% <0%> (-0.3%) ⬇️
sourmash/sbt_storage.py 86.66% <0%> (+0.95%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddaae07...67be738. Read the comment docs.

@luizirber luizirber merged commit 7e99e85 into master Jan 6, 2020
19 of 20 checks passed
19 of 20 checks passed
Check
Details
build
Details
test (beta)
Details
test (stable)
Details
test (windows)
Details
test (macos)
Details
test_all_features
Details
coverage
Details
Lints
Details
Check if wasm-pack builds a valid package for the sourmash crate
Details
Run tests under wasm32-wasi Run tests under wasm32-wasi
Details
Publish (dry-run)
Details
minimum_rust_version
Details
Travis CI - Pull Request Build Errored
Details
LGTM analysis: C/C++ No code changes detected
Details
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No code changes detected
Details
codecov/patch Coverage not affected when comparing ddaae07...67be738
Details
codecov/project 90.9% (+11.72%) compared to ddaae07
Details
netlify/sourmash-docs/deploy-preview Deploy preview ready!
Details
@luizirber luizirber deleted the rtd_37 branch Jan 6, 2020
@luizirber luizirber added this to the 3.1 milestone Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.