Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] ugly fix while new ipfshttpclient is not released #833

Open
wants to merge 6 commits into
base: master
from

Conversation

@luizirber
Copy link
Member

luizirber commented Jan 7, 2020

ipfshttpclient is broken for large files, this is an ugly solution until ipfs/py-ipfs-http-client#194 is merged and released.

Checklist

  • Is it mergeable?
  • make test Did it pass the tests?
  • make coverage Is the new code covered?
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Was a spellchecker run on the source code and documentation after
    changes were made?
@codecov

This comment has been minimized.

Copy link

codecov bot commented Jan 7, 2020

Codecov Report

Merging #833 into master will increase coverage by 12.3%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #833      +/-   ##
==========================================
+ Coverage   79.21%   91.52%   +12.3%     
==========================================
  Files          45       32      -13     
  Lines        6707     4800    -1907     
  Branches      469        0     -469     
==========================================
- Hits         5313     4393     -920     
+ Misses       1094      407     -687     
+ Partials      300        0     -300
Flag Coverage Δ
#pytests 90.42% <ø> (ø) ⬆️
#rusttests ?
Impacted Files Coverage Δ
src/core/src/from.rs
src/core/src/sketch/minhash.rs
src/core/src/index/sbt/mhbt.rs
src/core/src/index/storage.rs
src/core/src/index/linear.rs
src/core/src/index/mod.rs
src/core/src/sketch/nodegraph.rs
src/core/src/index/search.rs
src/core/src/signature.rs
src/core/src/index/bigsi.rs
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a2a14e...2f19df4. Read the comment docs.

@luizirber luizirber changed the title ugly fix while new ipfshttpclient is not released [WIP] ugly fix while new ipfshttpclient is not released Jan 7, 2020
luizirber added 5 commits Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.