Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger new Software Heritage archival snapshot on new tags #839

Merged
merged 2 commits into from Jan 15, 2020

Conversation

@luizirber
Copy link
Member

luizirber commented Jan 12, 2020

The Software Heritage project has an API for triggering new snapshots of the code. I added a new job to GitHub Actions to trigger it on new tags.

Checklist

  • Is it mergeable?
  • make test Did it pass the tests?
  • make coverage Is the new code covered?
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Was a spellchecker run on the source code and documentation after
    changes were made?
@luizirber

This comment has been minimized.

Copy link
Member Author

luizirber commented Jan 12, 2020

In the future this job might go into a new workflow (not the Rust one) that also checks codemeta.json and other metadata.

@luizirber

This comment has been minimized.

Copy link
Member Author

luizirber commented Jan 12, 2020

Ready for review and merge @ctb

@codecov

This comment has been minimized.

Copy link

codecov bot commented Jan 12, 2020

Codecov Report

Merging #839 into master will decrease coverage by 11.27%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #839       +/-   ##
===========================================
- Coverage   90.39%   79.11%   -11.28%     
===========================================
  Files          70       83       +13     
  Lines        5090     7025     +1935     
  Branches        0      469      +469     
===========================================
+ Hits         4601     5558      +957     
- Misses        489     1167      +678     
- Partials        0      300      +300
Flag Coverage Δ
#pytests 89.91% <ø> (?)
#rusttests 48.71% <ø> (?)
Impacted Files Coverage Δ
src/core/src/from.rs 71.66% <0%> (ø)
src/core/src/sketch/minhash.rs 34.43% <0%> (ø)
src/core/src/lib.rs 52.19% <0%> (ø)
src/core/src/index/storage.rs 72.22% <0%> (ø)
src/core/src/index/linear.rs 91.66% <0%> (ø)
src/core/src/index/bigsi.rs 60.86% <0%> (ø)
src/core/src/sketch/nodegraph.rs 42.78% <0%> (ø)
src/core/src/index/search.rs 100% <0%> (ø)
src/core/src/signature.rs 37.58% <0%> (ø)
src/core/src/index/mod.rs 56.41% <0%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bd286b...a04d980. Read the comment docs.

@ctb
ctb approved these changes Jan 12, 2020
@luizirber luizirber added this to the 3.1 milestone Jan 14, 2020
@luizirber luizirber force-pushed the ci_archive_heritage branch from de7abe2 to a04d980 Jan 15, 2020
@luizirber luizirber merged commit 971594d into master Jan 15, 2020
18 of 19 checks passed
18 of 19 checks passed
archive
Details
Check
Details
build
Details
test (beta)
Details
test (stable)
Details
test (windows)
Details
test (macos)
Details
test_all_features
Details
coverage
Details
Lints
Details
Check if wasm-pack builds a valid package for the sourmash crate
Details
Run tests under wasm32-wasi Run tests under wasm32-wasi
Details
Publish (dry-run)
Details
minimum_rust_version
Details
Travis CI - Pull Request Build Errored
Details
LGTM analysis: C/C++ No code changes detected
Details
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No code changes detected
Details
netlify/sourmash-docs/deploy-preview Deploy preview canceled.
Details
@luizirber luizirber deleted the ci_archive_heritage branch Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.