Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better sourmash compare error handling #876

Merged
merged 3 commits into from Feb 5, 2020
Merged

Conversation

@ctb
Copy link
Member

ctb commented Jan 28, 2020

Error out with correct error messages when files don't exist or no signatures are found.

Also adds a -f/--force argument.

Fixes #858.

  • Is it mergeable?
  • make test Did it pass the tests?
  • make coverage Is the new code covered?
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Was a spellchecker run on the source code and documentation after
    changes were made?
@codecov

This comment has been minimized.

Copy link

codecov bot commented Jan 28, 2020

Codecov Report

❗️ No coverage uploaded for pull request base (master@e4f41e1). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #876   +/-   ##
=========================================
  Coverage          ?   91.38%           
=========================================
  Files             ?       70           
  Lines             ?     4943           
  Branches          ?        0           
=========================================
  Hits              ?     4517           
  Misses            ?      426           
  Partials          ?        0
Impacted Files Coverage Δ
sourmash/sbt.py 86.52% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4f41e1...c6e9f8e. Read the comment docs.

@ctb

This comment has been minimized.

Copy link
Member Author

ctb commented Jan 28, 2020

Ready for review & merge @luizirber @bluegenes

@luizirber luizirber changed the title [MRG] better sourmash compare error handling Better sourmash compare error handling Feb 5, 2020
ctb and others added 2 commits Feb 5, 2020
@luizirber luizirber merged commit fd492b5 into master Feb 5, 2020
8 of 9 checks passed
8 of 9 checks passed
archive
Details
build
Details
Travis CI - Pull Request Build Canceled
Details
LGTM analysis: C/C++ No code changes detected
Details
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No new or fixed alerts
Details
codecov/patch No report found to compare against
Details
codecov/project No report found to compare against
Details
netlify/sourmash-docs/deploy-preview Deploy preview canceled.
Details
@luizirber luizirber deleted the add/compare_file_noexist branch Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.