Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-add 'signature' as alias for 'sig' #881

Merged
merged 5 commits into from Feb 4, 2020
Merged

Conversation

@ctb
Copy link
Member

ctb commented Feb 1, 2020

Fixes #880

  • Is it mergeable?
  • make test Did it pass the tests?
  • make coverage Is the new code covered?
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Was a spellchecker run on the source code and documentation after
    changes were made?
ctb added 2 commits Feb 1, 2020
@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 1, 2020

Codecov Report

Merging #881 into master will decrease coverage by 0.22%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #881      +/-   ##
==========================================
- Coverage   91.57%   91.34%   -0.23%     
==========================================
  Files          69       70       +1     
  Lines        4902     4936      +34     
==========================================
+ Hits         4489     4509      +20     
- Misses        413      427      +14
Impacted Files Coverage Δ
sourmash/cli/signature/__init__.py 100% <100%> (ø)
sourmash/cli/__init__.py 98.9% <100%> (+0.06%) ⬆️
sourmash/_compat.py 50% <0%> (-50%) ⬇️
sourmash/lca/lca_utils.py 95.98% <0%> (-0.62%) ⬇️
sourmash/lca/command_index.py 91.77% <0%> (-0.44%) ⬇️
sourmash/sbt.py 86.52% <0%> (-0.29%) ⬇️
sourmash/sbt_storage.py 86.36% <0%> (+0.97%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed5be32...f2777fb. Read the comment docs.

@ctb

This comment has been minimized.

Copy link
Member Author

ctb commented Feb 1, 2020

@ctb

This comment has been minimized.

Copy link
Member Author

ctb commented Feb 1, 2020

ready for review @taylorreiter @luizirber

@luizirber luizirber changed the title [MRG] re-add 'signature' as alias for 'sig' re-add 'signature' as alias for 'sig' Feb 1, 2020
@luizirber

This comment has been minimized.

Copy link
Member

luizirber commented Feb 1, 2020

Too bad it shows both sig and signature in the sourmash --help message, maybe keep just signature and leave sig as a shortcut (but not mentioned?)

@luizirber

This comment has been minimized.

Copy link
Member

luizirber commented Feb 1, 2020

Also: release this as 3.2.1

@luizirber

This comment has been minimized.

Copy link
Member

luizirber commented Feb 4, 2020

Ended up adding an alias mapping in e07dc5e, what do you think @ctb?

@ctb

This comment has been minimized.

Copy link
Member Author

ctb commented Feb 4, 2020

@luizirber luizirber force-pushed the fix/add_signature_alias branch from e07dc5e to f2777fb Feb 4, 2020
@luizirber luizirber merged commit bb90fc9 into master Feb 4, 2020
9 checks passed
9 checks passed
archive
Details
build
Details
LGTM analysis: C/C++ No code changes detected
Details
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No new or fixed alerts
Details
Travis CI - Pull Request Build Passed
Details
codecov/patch 100% of diff hit (target 91.57%)
Details
codecov/project Absolute coverage decreased by -0.22% but relative coverage increased by +8.42% compared to ed5be32
Details
netlify/sourmash-docs/deploy-preview Deploy preview canceled.
Details
@luizirber luizirber deleted the fix/add_signature_alias branch Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.