Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: add_hash with num doesn't set abundances properly #891

Merged
merged 2 commits into from Feb 6, 2020
Merged

Conversation

@luizirber
Copy link
Member

luizirber commented Feb 6, 2020

Found this while updating #661. All our tests use scaled MH, so this didn't pop up...

Checklist

  • Is it mergeable?
  • make test Did it pass the tests?
  • make coverage Is the new code covered?
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Was a spellchecker run on the source code and documentation after
    changes were made?
luizirber added 2 commits Feb 6, 2020
@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 6, 2020

Codecov Report

Merging #891 into master will increase coverage by 0.19%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #891      +/-   ##
==========================================
+ Coverage   78.01%   78.21%   +0.19%     
==========================================
  Files          95       95              
  Lines        7310     7311       +1     
==========================================
+ Hits         5703     5718      +15     
+ Misses       1607     1593      -14
Flag Coverage Δ
#rusttests 50.14% <100%> (ø) ⬆️
Impacted Files Coverage Δ
src/core/src/sketch/minhash.rs 69.26% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02b354d...3df2727. Read the comment docs.

@luizirber luizirber force-pushed the bug_add_hash branch from f577597 to 3df2727 Feb 6, 2020
@luizirber

This comment has been minimized.

Copy link
Member Author

luizirber commented Feb 6, 2020

Ready for review and merge @ctb

@ctb
ctb approved these changes Feb 6, 2020
@ctb ctb merged commit 3ec5ce3 into master Feb 6, 2020
35 checks passed
35 checks passed
archive
Details
archive
Details
Check
Details
Check
Details
build
Details
build
Details
test (beta)
Details
test (beta)
Details
test (stable)
Details
test (stable)
Details
test (windows)
Details
test (windows)
Details
test (macos)
Details
test (macos)
Details
test_all_features
Details
test_all_features
Details
coverage
Details
coverage
Details
Lints
Details
Lints
Details
Check if wasm-pack builds a valid package for the sourmash crate
Details
Check if wasm-pack builds a valid package for the sourmash crate
Details
Run tests under wasm32-wasi Run tests under wasm32-wasi
Details
Run tests under wasm32-wasi Run tests under wasm32-wasi
Details
Publish (dry-run)
Details
Publish (dry-run)
Details
minimum_rust_version
Details
minimum_rust_version
Details
LGTM analysis: C/C++ No code changes detected
Details
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No new or fixed alerts
Details
Travis CI - Pull Request Build Passed
Details
codecov/patch 100% of diff hit (target 78.01%)
Details
codecov/project 78.21% (+0.19%) compared to 02b354d
Details
netlify/sourmash-docs/deploy-preview Deploy preview canceled.
Details
@luizirber luizirber deleted the bug_add_hash branch Feb 7, 2020
@luizirber luizirber mentioned this pull request Feb 7, 2020
5 of 5 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.