Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing pen color and using a theme can cause text to be unreadable #62

Closed
Dibasic opened this issue Mar 20, 2019 · 4 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@Dibasic
Copy link
Owner

Dibasic commented Mar 20, 2019

Describe the bug
The only unintended behavior here is that changing your pen color back to 'black' locks it at black and isn't overwritten by color schemes.

To Reproduce
Steps to reproduce the behavior:

  1. Set pen color to "Blue"
  2. Set theme to "Solarized (Dark)"
  3. Realize that looks bad, set pen color to "Black" to reset it
  4. You now have black on teal instead of the default solarized color.

Expected behavior
Combining these features should do one of two things:

  1. Lock out the pen color feature entirely while the theme is not default white.
  2. Have the 'Black' pen color instead default to the theme's default text color. Rename 'Black' to 'Black (Default)' or similar.

Web Browser (please complete the following information):

  • Firefox 65.0.2

Screenshots
image

Pen Code

Additional context

@Dibasic Dibasic added the bug Something isn't working label Mar 20, 2019
@soryy708
Copy link
Contributor

"Invisible" should be white on white, but becomes extra visible on solarized and black.

@Dibasic
Copy link
Owner Author

Dibasic commented Mar 21, 2019

This is where custom properties could be nice. Setting '--defaultTextColor' to be black on the default, white on high-contrast, base0 on Solarized, etc should work

@soryy708
Copy link
Contributor

@Dibasic Dibasic self-assigned this Mar 25, 2019
Dibasic added a commit that referenced this issue Mar 25, 2019
Fix #62 
- Make black instead remove any text color override
- Make 'invisible' (white antag pen) instead use background color
- Recursively apply color to penetrate (possibly differently-colored) children like headers or tables
@soryy708
Copy link
Contributor

Fix was not adequate. #67

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants