Skip to content

#841: docs: update DBSIZE docs#946

Merged
JyotinderSingh merged 4 commits intodicedb:masterfrom
kishanhitk:docs--DBSIZE-command-improvement
Oct 13, 2024
Merged

#841: docs: update DBSIZE docs#946
JyotinderSingh merged 4 commits intodicedb:masterfrom
kishanhitk:docs--DBSIZE-command-improvement

Conversation

@kishanhitk
Copy link
Contributor

@kishanhitk kishanhitk commented Oct 4, 2024

ref: #841

@AshwinKul28
Copy link
Contributor

HI @kishanhitk Changes look good, can you please add an Error example as well if possible? thanks

@kishanhitk
Copy link
Contributor Author

@AshwinKul28
According to the current docs, it throws the NOPERM error when the current user doesn’t have the necessary permissions to run this command.
However, I can’t seem to find any information about user permissions in the source code or the current docs.

@JyotinderSingh
Copy link
Contributor

@AshwinKul28

According to the current docs, it throws the NOPERM error when the current user doesn’t have the necessary permissions to run this command.

However, I can’t seem to find any information about user permissions in the source code or the current docs.

We haven't implemented permissions for this command yet. Could you please create an issue for the same? Hopefully someone will pick it up.

@kishanhitk kishanhitk marked this pull request as ready for review October 13, 2024 13:48
@kishanhitk
Copy link
Contributor Author

@JyotinderSingh

I've removed the NOPERM error from the docs for now. We can proceed with merging this PR. I'll create a new PR with the NOPERM example once the feature is ready.

Regarding the issue for permission management for this command, you mentioned:

We haven't implemented permissions for this command yet

I am a bit confused. Does this mean the ACL feature already exists in DiceDB, and we just need to extend it to cover the DBSIZE command? I ask because I couldn't find any references to ACL in the current source code or docs. Also, the ACL command doesn't seem to work in the current version of DiceDB.

Given this, I'm thinking we should create an issue for implementing the ACL feature in DiceDB as a whole, rather than specifically "Implementing permissions for DBSIZE."

Let me know if I'm misunderstanding anything here.

@JyotinderSingh
Copy link
Contributor

JyotinderSingh commented Oct 13, 2024

@JyotinderSingh

I've removed the NOPERM error from the docs for now. We can proceed with merging this PR. I'll create a new PR with the NOPERM example once the feature is ready.

Regarding the issue for permission management for this command, you mentioned:

We haven't implemented permissions for this command yet

I am a bit confused. Does this mean the ACL feature already exists in DiceDB, and we just need to extend it to cover the DBSIZE command? I ask because I couldn't find any references to ACL in the current source code or docs. Also, the ACL command doesn't seem to work in the current version of DiceDB.

Given this, I'm thinking we should create an issue for implementing the ACL feature in DiceDB as a whole, rather than specifically "Implementing permissions for DBSIZE."

Let me know if I'm misunderstanding anything here.

Your understanding is correct, we don't currently support ACLs in dicedb. We will tackle this separately, we should create an issue for the same.

@JyotinderSingh JyotinderSingh changed the title docs: update DBSIZE docs #841: docs: update DBSIZE docs Oct 13, 2024
@JyotinderSingh JyotinderSingh merged commit 8eaa4f5 into dicedb:master Oct 13, 2024
kakdeykaushik pushed a commit to kakdeykaushik/dice that referenced this pull request Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants