"Two-word briefs You *" lesson fixes #525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Mark `KOU` for "you could" as a mis-stroke - Add `KOU` for "cow" to `dict.json` - Change Gutenberg dictionary outline preference for "cow" to `KOU`
- Mark `TKU` for "you did" as a mis-stroke - Correct `TKU` entry in `dict.json` to be "did you"
fix the entries in `dict.json` and mark their original outlines as mis-strokes.
- Mark `TKPWU` for "you go" as a mis-stroke - Fix `TKPWU` entry in `dict.json` to be "Gu"
- Mark `SRU` for "you have" as a mis-stroke - Fix `SRU` entry in `dict.json` to have value "have you"
- Mark `URL` for "you recall" as a mis-stroke - Fix `URL` entry in `dict.json` to have value "URL"
Therefore, - Mark `URBGD` for "you recollected" as a mis-stroke - Fix `URBGD` entry in `dict.json` to have value "understanding"
…/HR`. Therefore, - Add `HR*U` for "you will" entry to `dict.json` - Mark `HRU` for "you will" as a mis-stroke - Fix `HRU` entry in `dict.json` to have value "will you" - Move `U/HR` for "you will" entry from `dict.json` to condensed strokes
|
Oof, this lesson looks like a mess. This may need some surgery to rebuild the lesson properly in light of the many changes in Plover dictionary. I'll need to come back to this. Thanks for the PR, @paulfioravanti |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes a range of dictionary fixes (details in each commit message) that came up for me working through Typey Type's Two-word briefs You * lesson.