Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix boolean typehint #24 #25

Merged
merged 1 commit into from Nov 5, 2019

Conversation

@gigorok
Copy link
Member

gigorok commented Nov 5, 2019

No description provided.

@gigorok gigorok changed the title fix boolean typehint #24 WIP: fix boolean typehint #24 Nov 5, 2019
@gigorok gigorok force-pushed the gigorok:boolean-fix branch from 1d7b0e0 to 14f25b8 Nov 5, 2019
@gigorok gigorok changed the title WIP: fix boolean typehint #24 fix boolean typehint #24 Nov 5, 2019
@gigorok gigorok requested a review from Fivell Nov 5, 2019
@Fivell

This comment has been minimized.

Copy link
Member

Fivell commented Nov 5, 2019

@gigorok please add test to https://github.com/didww/didww-api-3-php-sdk/blob/master/tests/DidTest.php so we can ensure no regressions in future

@gigorok gigorok force-pushed the gigorok:boolean-fix branch 2 times, most recently from e6dacb1 to da01ee4 Nov 5, 2019
@gigorok

This comment has been minimized.

Copy link
Member Author

gigorok commented Nov 5, 2019

@gigorok please add test to https://github.com/didww/didww-api-3-php-sdk/blob/master/tests/DidTest.php so we can ensure no regressions in future

ok, also I noticed that getNumber method returns boolean (wrong), add test to it as well

@gigorok gigorok force-pushed the gigorok:boolean-fix branch from da01ee4 to 1978312 Nov 5, 2019
@gigorok gigorok merged commit eb7c44a into didww:master Nov 5, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+2.5%) to 59.7%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.