From 660265a19a6ec3615cc1066d5ecbd70a26819e29 Mon Sep 17 00:00:00 2001 From: Wojciech Maj Date: Fri, 19 Jan 2024 00:57:27 +0100 Subject: [PATCH] fix: remove unnecessary check for response.buffer If TypeScript is to be believed, cross-fetch's Response never returns buffer, so this check is unnecessary. --- .changeset/slimy-suns-drive.md | 5 +++++ packages/image/src/resolve.js | 4 +--- 2 files changed, 6 insertions(+), 3 deletions(-) create mode 100644 .changeset/slimy-suns-drive.md diff --git a/.changeset/slimy-suns-drive.md b/.changeset/slimy-suns-drive.md new file mode 100644 index 000000000..1dbe398e8 --- /dev/null +++ b/.changeset/slimy-suns-drive.md @@ -0,0 +1,5 @@ +--- +'@react-pdf/image': patch +--- + +Remove unnecessary check for response.buffer diff --git a/packages/image/src/resolve.js b/packages/image/src/resolve.js index 6bee8270b..57fb9a1ad 100644 --- a/packages/image/src/resolve.js +++ b/packages/image/src/resolve.js @@ -47,9 +47,7 @@ const fetchLocalFile = src => const fetchRemoteFile = async (uri, options) => { const response = await fetch(uri, options); - const buffer = await (response.buffer - ? response.buffer() - : response.arrayBuffer()); + const buffer = await response.arrayBuffer(); return buffer.constructor.name === 'Buffer' ? buffer : Buffer.from(buffer); };