Diego Nehab diegonehab

diegonehab commented on issue diegonehab/luasocket#99
@diegonehab

I think in 3 we should simply try the first address. Simpler to code. The only people that would care about this would know what to do anyway. Nobo…

diegonehab commented on issue diegonehab/luasocket#99
@diegonehab

You'd be surprised. I don't think we need to add the test. What we definitely need to add is that error checking that you suggested. I.e., if the s…

diegonehab commented on issue diegonehab/luasocket#99
@diegonehab

To be absolutely sure, we would need to distinguish between numeric and named addresses ourselves, and then pass the appropriate flag to getaddrinf…

diegonehab commented on issue diegonehab/luasocket#99
@diegonehab

The "standard way of doing things" states that these addresses should be tried in sequence. The OS doesn't do this because each call to the OS conn…

diegonehab commented on pull request diegonehab/luasocket#131
@diegonehab

I agree 133 would be preferrable to the previous one. But I am still trying to understand the root of the problem here. I don't see any private fun…

diegonehab commented on issue diegonehab/luasocket#99
@diegonehab

The issue with non-blocking connects with names that resolve to multiple addresses is: what does that mean? When the connect is blocking, we go ove…

diegonehab commented on issue diegonehab/luasocket#99
@diegonehab

Is there a minimum number of changes that would unify Windows and Unix behavior without completely changing the way we do things in LuaSocket? This…

diegonehab commented on pull request diegonehab/luasocket#131
@diegonehab

So the code that is replicated in https.lua is the 16 lines of code in http.lua that convert the simple request in to a table request?

diegonehab commented on pull request diegonehab/luasocket#131
@diegonehab

I don't like the create() in the simple form. This is because create() is a pretty advanced feature. More advanced than the sink(), for instance. S…

diegonehab commented on pull request diegonehab/luasocket#132
@diegonehab

No problem. :)

diegonehab commented on pull request diegonehab/luasocket#132
@diegonehab

There was a typo on usocket.c. Did you try compiling?

@diegonehab
diegonehab merged pull request diegonehab/luasocket#132
@diegonehab
updated error messages, less error prone, platform independent
1 commit with 78 additions and 51 deletions
@diegonehab
diegonehab merged pull request diegonehab/luasocket#115
@diegonehab
white background
1 commit with 1 addition and 0 deletions
diegonehab closed pull request diegonehab/luasocket#131
@diegonehab
Updated ftp and http methods for better async support
diegonehab commented on pull request diegonehab/luasocket#131
@diegonehab

The async support was already trivial in HTTP, which honors the "create" field in the request table. I prefer not to include a second argument "cre…

@diegonehab
diegonehab merged pull request diegonehab/luasocket#119
@diegonehab
Make casts const correct.
4 commits with 13 additions and 20 deletions
diegonehab commented on issue diegonehab/luasocket#99
@diegonehab

It would be great if somebody could figure out the portable way for doing non-blocking connects in LuaSocket so that users can forget if they are o…

@diegonehab
  • 8396a02
    Better solution to luaL_checkint...
@diegonehab
diegonehab merged pull request diegonehab/luasocket#128
@diegonehab
fixed accidental global in `ftp.lua`
1 commit with 1 addition and 1 deletion
@diegonehab
inet_global_getaddrinfo leaks resolved if getnameinfo fails
@diegonehab

Thanks! Fixed.

@diegonehab
  • 76ed24f
    Fix inet_global_getaddrinfo leak of getnameinfo
@diegonehab
  • ddf4292
    Out of the box support for Lua 5.3.
@diegonehab

This is no a LuaSocket problem. It's LuaJIT that is not compatible with Lua 5.2. So if you compile LuaSocket for Lua 5.2, how is it going to work w…

@diegonehab

If I recall correctly, LuaJit is for Lua 5.1...

@diegonehab

Should. Doesn't it?