New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert ionic seed app to generator-angular standards #19

Open
douglascorrea opened this Issue Mar 21, 2014 · 10 comments

Comments

Projects
None yet
8 participants
@douglascorrea

douglascorrea commented Mar 21, 2014

When use:

yo angular:[command]

it creates controllers, services, views and so on, in generator-angular default folders that is different from Ionic seed standard.

Maybe if generator-ionic uses an seed app with generator-angular defaults could be better to continue using yo angular:[commands]

@diegonetto

This comment has been minimized.

Show comment
Hide comment
@diegonetto

diegonetto Mar 21, 2014

Owner

I was considering pulling in generator-angular as a sub-generator, but hadn't made a decision yet. I'm leaning more towards it being a good idea, in which case the seed app will indeed have to be restructured.

Will see if I can knock this out tonight.

Owner

diegonetto commented Mar 21, 2014

I was considering pulling in generator-angular as a sub-generator, but hadn't made a decision yet. I'm leaning more towards it being a good idea, in which case the seed app will indeed have to be restructured.

Will see if I can knock this out tonight.

@mhartington

This comment has been minimized.

Show comment
Hide comment
@mhartington

mhartington Apr 1, 2014

Hey any progress on this?

mhartington commented Apr 1, 2014

Hey any progress on this?

@diegonetto

This comment has been minimized.

Show comment
Hide comment
@diegonetto

diegonetto Apr 1, 2014

Owner

None so far since I ended up focusing my efforts on other areas of the generator. However, of all the open enhancement requests, this is priority number one on my list.

Owner

diegonetto commented Apr 1, 2014

None so far since I ended up focusing my efforts on other areas of the generator. However, of all the open enhancement requests, this is priority number one on my list.

@diegonetto diegonetto self-assigned this Apr 1, 2014

@diegonetto diegonetto added this to the Version 0.3.0 milestone Apr 1, 2014

@robkorv

This comment has been minimized.

Show comment
Hide comment
@robkorv

robkorv Apr 1, 2014

Today I decided to just give generator-angular inside the Ionic dir a go.

I can use the generators. Avoid angular:app (will generate a complete angular app) and angular:route (will generate, controller, view and route while Ionic uses AngularUI for routing).

I can confirm that angular:controller and angular:view works while using grunt serve. Apart from some different dir usage, it's pretty functional.

robkorv commented Apr 1, 2014

Today I decided to just give generator-angular inside the Ionic dir a go.

I can use the generators. Avoid angular:app (will generate a complete angular app) and angular:route (will generate, controller, view and route while Ionic uses AngularUI for routing).

I can confirm that angular:controller and angular:view works while using grunt serve. Apart from some different dir usage, it's pretty functional.

@deedubbleyoo

This comment has been minimized.

Show comment
Hide comment
@deedubbleyoo

deedubbleyoo Apr 1, 2014

Good to know that a lot of the standard generators work: my team was asking for this today - it would be great if you full integrated yo angular (or a version that handles ui-router etc.) into the generator.

Kudos on this project - we have become super-productive and have been able to re-scaffold an app in days compared to months for the previous application.

deedubbleyoo commented Apr 1, 2014

Good to know that a lot of the standard generators work: my team was asking for this today - it would be great if you full integrated yo angular (or a version that handles ui-router etc.) into the generator.

Kudos on this project - we have become super-productive and have been able to re-scaffold an app in days compared to months for the previous application.

@JaKXz

This comment has been minimized.

Show comment
Hide comment
@JaKXz

JaKXz May 5, 2014

Contributor

Any progress on getting a ui-router generator working?

This generator looks promising! 😄

Contributor

JaKXz commented May 5, 2014

Any progress on getting a ui-router generator working?

This generator looks promising! 😄

@diegonetto

This comment has been minimized.

Show comment
Hide comment
@diegonetto

diegonetto May 5, 2014

Owner

Looking to start pulling in generator-angular towards the end of this week.

Owner

diegonetto commented May 5, 2014

Looking to start pulling in generator-angular towards the end of this week.

@diegonetto diegonetto closed this May 5, 2014

@diegonetto diegonetto reopened this May 5, 2014

@diegonetto

This comment has been minimized.

Show comment
Hide comment
@diegonetto

diegonetto May 14, 2014

Owner

Was about to post a design discussion topic about directory structure, since for all of my contract projects I've been using a component-centric directory structure instead of generator-angular's controllers/, directives/, services/, etc structure. I've found that a component-driven architecture makes working on large projects much more manageable.

This proposal was brought to my attention today by @jcumminsr1, so I'm holding off on pulling in the Angular Generator until we see how it shakes out.

Ultimately, I'd like to support generator-angular's adoption of the fractal hierarchy described in that proposal, since its almost identical to what I, and many others, have been using for large industry projects.

Owner

diegonetto commented May 14, 2014

Was about to post a design discussion topic about directory structure, since for all of my contract projects I've been using a component-centric directory structure instead of generator-angular's controllers/, directives/, services/, etc structure. I've found that a component-driven architecture makes working on large projects much more manageable.

This proposal was brought to my attention today by @jcumminsr1, so I'm holding off on pulling in the Angular Generator until we see how it shakes out.

Ultimately, I'd like to support generator-angular's adoption of the fractal hierarchy described in that proposal, since its almost identical to what I, and many others, have been using for large industry projects.

@alexkb

This comment has been minimized.

Show comment
Hide comment
@alexkb

alexkb Dec 8, 2014

We're trialing Ionic and Angular and wanted to use yo angular:<type> <name> to create controllers, directives and services. It seems to work fine with a project created with generator-ionic, except for the way generator-angular detects the angular module name. It detects the module name, but converts it to lowercase and appends "App" to the end. Manually editing this resolves the problem for the time being but it would be good for this to work out of the box.

As for the discussion on fractal hierarchy, we aren't at the stage yet where the application is so large it needs all this separation.

alexkb commented Dec 8, 2014

We're trialing Ionic and Angular and wanted to use yo angular:<type> <name> to create controllers, directives and services. It seems to work fine with a project created with generator-ionic, except for the way generator-angular detects the angular module name. It detects the module name, but converts it to lowercase and appends "App" to the end. Manually editing this resolves the problem for the time being but it would be good for this to work out of the box.

As for the discussion on fractal hierarchy, we aren't at the stage yet where the application is so large it needs all this separation.

@LunarDevelopment

This comment has been minimized.

Show comment
Hide comment
@LunarDevelopment

LunarDevelopment Jun 12, 2015

Any further progress with this?

+1

LunarDevelopment commented Jun 12, 2015

Any further progress with this?

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment