Diego Pacheco
diegopacheco

Jul 20, 2016
diegopacheco commented on issue Netflix/dynomite#305
@diegopacheco

Hi @ipapapa I did not see it happen anymore.... I think you can close it.

Jul 19, 2016
@diegopacheco
  • @ipapapa 5955605
    Merge pull request #16 from diegopacheco/dev
Jul 19, 2016
diegopacheco commented on pull request Netflix/dynomite-manager#16
@diegopacheco

@ipapapa tks np.

Jul 19, 2016
@diegopacheco

@ipapapa The bindings are correct now I tested. As we move to integration tests we will have tests to catch this kinda of things.

Jul 19, 2016
Jul 19, 2016
@diegopacheco
FIX Issue #15
2 commits with 7 additions and 0 deletions
Jul 19, 2016
@diegopacheco
No implementation for com.netflix.dynomitemanager.sidecore.backup.Backup was bound.
Jul 19, 2016
@diegopacheco
  • @diegopacheco 80100bc
    fix No implementation for com.netflix.dynomitemanager.sidecore.backup…
Jul 19, 2016
@diegopacheco
  • @diegopacheco 327dbe1
    fix issue: No implementation for com.netflix.dynomitemanager.sidecore…
Jul 19, 2016
@diegopacheco

Well done @ipapapa very nice!

Jul 19, 2016
@diegopacheco
Jul 19, 2016
@diegopacheco
  • @ipapapa 0fd0eb0
    Merge pull request #13 from diegopacheco/dev
Jul 19, 2016
@diegopacheco
  • @diegopacheco 382d1e4
    added errors and timeouts
Jul 19, 2016
@diegopacheco
Jul 19, 2016
@diegopacheco
Jul 18, 2016
diegopacheco commented on pull request Netflix/dynomite-manager#13
@diegopacheco

Done @ipapapa

Jul 18, 2016
diegopacheco commented on pull request Netflix/dynomite-manager#13
@diegopacheco

done.

Jul 18, 2016
@diegopacheco
  • @diegopacheco ab336ff
    Added a var to express the metrics counter for the Redis_info command
Jul 18, 2016
diegopacheco commented on pull request Netflix/dynomite-manager#13
@diegopacheco

26 is the count of metrics that will be there given the REDIS_INFO sample.... I can create a method that express that or variable to would be easi…

Jul 18, 2016
diegopacheco commented on pull request Netflix/dynomite-manager#13
@diegopacheco

Yes. And to make easier to tests other method on the future.

Jul 18, 2016
diegopacheco commented on pull request Netflix/dynomite-manager#13
@diegopacheco

Yes safety check and validation. IF this is retry based IMHO needs to be 0 in other words no retry or any positive number.

Jul 18, 2016
diegopacheco commented on pull request Netflix/dynomite-manager#13
@diegopacheco

For validation... IF we dont do it It will fail. So as a Good practice I added the validation there so If someone does not pass it we can easy spot…

Jul 18, 2016
@diegopacheco
Added 32 Unit Tests for Dynomite Manager
4 commits with 1,006 additions and 17 deletions