Skip to content

CRITICAL security vuln fixed#83

Closed
gsovereignty wants to merge 1 commit into
diem:masterfrom
gsovereignty:vuln
Closed

CRITICAL security vuln fixed#83
gsovereignty wants to merge 1 commit into
diem:masterfrom
gsovereignty:vuln

Conversation

@gsovereignty

@gsovereignty gsovereignty commented Jun 19, 2019

Copy link
Copy Markdown

I've discovered an alarming vulnerability, but fortunately there's a really simple fix so I've sent a pull request to address it.

In the current implementation, trusted 'validator nodes' are core to the security model. This means that hard power is centralised around these few entities. The protocol itself depends on these entities to (as the name suggests) validate the protocol. This means the protocol is whatever they decide it is. These entities can change the rules whenever they want. This means they can freeze your coins, take your coins, issue new coins, or really whatever they want - the sky is the limit.

This problem can easily be solved by using a permissionless system where the hard power is decentralised across a very large number of participants in such a way that making changes to the protocol is impossible without near unanimous agreement by everyone involved.

This pull request contains a patch to the existing codebase to resolve this issue.

Edit: related issue: bnb-chain/node-binary#36

@tzarebczan

Copy link
Copy Markdown

ACK.

@tamasblummer

Copy link
Copy Markdown

Concept ACK
utACK

@DESIGNfromWITHIN

Copy link
Copy Markdown

Hahahaha Epic SIR!

@SamSamskies

Copy link
Copy Markdown

lgtm

@Kukks

Kukks commented Jun 19, 2019

Copy link
Copy Markdown

This seems to address a number of issues acknowledged on the whitepaper, great work!

@OverSoft

Copy link
Copy Markdown

ACK
This commit fixed all issues.

@tiero

tiero commented Jun 19, 2019

Copy link
Copy Markdown

tACK

@Kixunil

Kixunil commented Jun 19, 2019

Copy link
Copy Markdown

tACK

@bvolpato

Copy link
Copy Markdown

LGTM

@mandelmonkey

Copy link
Copy Markdown

ACK

@Kixunil

Kixunil commented Jun 19, 2019

Copy link
Copy Markdown

Fixes #57 and #35

@pretyflaco

Copy link
Copy Markdown

ACK

@amanusk

amanusk commented Jun 19, 2019

Copy link
Copy Markdown

Fixed it for me!

@lorenzodisidoro

Copy link
Copy Markdown

Now ready to be released 🚀

@gpestana gpestana left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird way to write Rust, but LGTM.

@backmeupplz

Copy link
Copy Markdown

Screen Shot 2019-06-19 at 9 25 29 AM

@Sizuji

Sizuji commented Jun 19, 2019

Copy link
Copy Markdown

ACK

1 similar comment
@kanemil

kanemil commented Jun 19, 2019

Copy link
Copy Markdown

ACK

@ohld

ohld commented Jun 19, 2019

Copy link
Copy Markdown

Perfect solution for decentralized future.

@eugenioclrc

Copy link
Copy Markdown

Great contribution! ACK!

@ddustin

ddustin commented Jun 19, 2019

Copy link
Copy Markdown

lgtm merge it in!

@hellc hellc left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice try!

@joaquinmoreira

Copy link
Copy Markdown

tACK

@dondreytaylor

Copy link
Copy Markdown

Wow, this pull request works perfectly on nimbleNODE (pocket size full node) too. Good stuff
https://nimblenode.io

@agiUnderground

Copy link
Copy Markdown

utACK

@viktor-berezin

Copy link
Copy Markdown

ACK

@melekhine

Copy link
Copy Markdown

Yeah, just merge this!!!

@adamtache adamtache left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nikandfor

Copy link
Copy Markdown

lgtm

@bonzofenix

Copy link
Copy Markdown

LGTM

1 similar comment
@bitstein

Copy link
Copy Markdown

LGTM

@blockchainwalletorg

Copy link
Copy Markdown

image

@binaryFate

Copy link
Copy Markdown

This PR does not address privacy concerns though, it only tackles the decentralization aspects but suggest to use a dangerously transparent blockchain.

@ericnakagawa

Copy link
Copy Markdown
Contributor

Libra initially uses a set of validators from Founding Members -- this helps to provide stability for the project in its early days. However, over the long run, validators will be selected only on their holdings of Libra, forming a permissionless system.

We believe that Libra can coexist with other currencies like Bitcoin -- Libra addresses a number of needs (like low-volatility) that other currencies do not address today.

@diem diem locked as off-topic and limited conversation to collaborators Jun 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.