-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CRITICAL security vuln fixed #83
Conversation
ACK. |
Concept ACK |
Hahahaha Epic SIR! |
lgtm |
This seems to address a number of issues acknowledged on the whitepaper, great work! |
ACK |
tACK |
tACK |
LGTM |
ACK |
ACK |
Fixed it for me! |
Now ready to be released 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Weird way to write Rust, but LGTM.
ACK |
1 similar comment
ACK |
Perfect solution for decentralized future. |
Great contribution! ACK! |
lgtm merge it in! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice try!
tACK |
Wow, this pull request works perfectly on nimbleNODE (pocket size full node) too. Good stuff |
utACK |
ACK |
Yeah, just merge this!!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
lgtm |
LGTM |
1 similar comment
LGTM |
This PR does not address privacy concerns though, it only tackles the decentralization aspects but suggest to use a dangerously transparent blockchain. |
Libra initially uses a set of validators from Founding Members -- this helps to provide stability for the project in its early days. However, over the long run, validators will be selected only on their holdings of Libra, forming a permissionless system. We believe that Libra can coexist with other currencies like Bitcoin -- Libra addresses a number of needs (like low-volatility) that other currencies do not address today. |
I've discovered an alarming vulnerability, but fortunately there's a really simple fix so I've sent a pull request to address it.
In the current implementation, trusted 'validator nodes' are core to the security model. This means that hard power is centralised around these few entities. The protocol itself depends on these entities to (as the name suggests) validate the protocol. This means the protocol is whatever they decide it is. These entities can change the rules whenever they want. This means they can freeze your coins, take your coins, issue new coins, or really whatever they want - the sky is the limit.
This problem can easily be solved by using a permissionless system where the hard power is decentralised across a very large number of participants in such a way that making changes to the protocol is impossible without near unanimous agreement by everyone involved.
This pull request contains a patch to the existing codebase to resolve this issue.
Edit: related issue: bnb-chain/node-binary#36