/diesel

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infer `operator_allowed!` for Timestamp types #1056

Closed
sgrif opened this Issue Aug 1, 2017 · 2 comments

Comments

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
3 participants
@sgrif @juliusdelta @Eijebong
@sgrif
Member

sgrif commented Aug 1, 2017

We already do this for numeric types, but date/time types specifically only allow add and sub. We should infer the required calls to operator_allowed! for those, the same way that we infer numeric_expr! in table! today.

@Eijebong Eijebong added the good first issue label Aug 1, 2017

@csharad csharad referenced this issue Aug 13, 2017

Merged

Added operator_allowed! for Timestamp types #1094

@juliusdelta

This comment has been minimized.

Sign in to view
Contributor

juliusdelta commented Aug 24, 2017 •
edited

Should this issue be closed per #1094 ?
@Eijebong

This comment has been minimized.

Sign in to view
Member

Eijebong commented Aug 24, 2017

Yep, thanks

@Eijebong Eijebong closed this Aug 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment