/diesel

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support `Timestamptz` #106

Closed
sgrif opened this Issue Jan 17, 2016 · 2 comments

Comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@sgrif @hayathms
@sgrif
Member

sgrif commented Jan 17, 2016

This should be separate from Timestamp. To start I would like to be incredibly conservative about any comparisons with these types, and not treat timestamp and timestamptz as interchangeable. I'm not super well versed in the semantics of this type -- it does sound like it mostly ends up being UTC on the backend, so we might be able to loosen this later.

@sgrif sgrif referenced this issue Jan 17, 2016

Closed

Support something useful for timestamps on stable #92

@sgrif

This comment has been minimized.

Sign in to view
Member

sgrif commented Jan 17, 2016

Any implementation which tackles this should likely handle https://github.com/sgrif/diesel/blob/c26d299da9b4b3e71b545c74dbc95ae13b2bbb98/diesel/src/expression/date_and_time.rs#L23 as well.

@anp anp referenced this issue May 4, 2016

Closed

Handle `DateTime` in addition to `NaiveDateTime` #295

sgrif added a commit that referenced this issue Aug 18, 2016

@sgrif
Add support for timestamp with time zone 
This adds support for the `timestamp with time zone` type. This is part
of the SQL standard, but not supported explicitly by SQLite as far as I
can tell. As such I've made it a PG specific type for now.

timestamp with time zone does not actually mean that a time zone is
stored. It instead means that when dealing with strings, Postgres will
no longer ignore the time zone portion. It will convert the time zone to
UTC for storage. When transmitted as text, it will be converted to the
database's local time zone. When transmitted as binary, it will be sent
as UTC.

As such, I've provided `ToSql` implementations for basically all flavors
of `DateTime`, but I've only provided a `FromSql` implementation for
`DateTime<UTC>` and `NaiveDateTime`. I have not provided any
implementation for `std::time::SystemTime`, as it implies local time
zone for the machine and we do not have the tools to handle the
conversion in the standard library.

Fixes #106.
Fixes #295.
Fixes #402.
2b1f748

sgrif added a commit that referenced this issue Aug 18, 2016

@sgrif
Add support for timestamp with time zone 
This adds support for the `timestamp with time zone` type. This is part
of the SQL standard, but not supported explicitly by SQLite as far as I
can tell. As such I've made it a PG specific type for now.

timestamp with time zone does not actually mean that a time zone is
stored. It instead means that when dealing with strings, Postgres will
no longer ignore the time zone portion. It will convert the time zone to
UTC for storage. When transmitted as text, it will be converted to the
database's local time zone. When transmitted as binary, it will be sent
as UTC.

As such, I've provided `ToSql` implementations for basically all flavors
of `DateTime`, but I've only provided a `FromSql` implementation for
`DateTime<UTC>` and `NaiveDateTime`. I have not provided any
implementation for `std::time::SystemTime`, as it implies local time
zone for the machine and we do not have the tools to handle the
conversion in the standard library.

Fixes #106.
Fixes #295.
Fixes #402.
b754898

@sgrif sgrif referenced this issue Aug 18, 2016

Merged

Add support for timestamp with time zone #409

sgrif added a commit that referenced this issue Aug 18, 2016

@sgrif
Add support for timestamp with time zone 
This adds support for the `timestamp with time zone` type. This is part
of the SQL standard, but not supported explicitly by SQLite as far as I
can tell. As such I've made it a PG specific type for now.

timestamp with time zone does not actually mean that a time zone is
stored. It instead means that when dealing with strings, Postgres will
no longer ignore the time zone portion. It will convert the time zone to
UTC for storage. When transmitted as text, it will be converted to the
database's local time zone. When transmitted as binary, it will be sent
as UTC.

As such, I've provided `ToSql` implementations for basically all flavors
of `DateTime`, but I've only provided a `FromSql` implementation for
`DateTime<UTC>` and `NaiveDateTime`. I have not provided any
implementation for `std::time::SystemTime`, as it implies local time
zone for the machine and we do not have the tools to handle the
conversion in the standard library.

Fixes #106.
Fixes #295.
Fixes #402.
b945040

sgrif added a commit that referenced this issue Aug 18, 2016

@sgrif
Add support for timestamp with time zone 
This adds support for the `timestamp with time zone` type. This is part
of the SQL standard, but not supported explicitly by SQLite as far as I
can tell. As such I've made it a PG specific type for now.

timestamp with time zone does not actually mean that a time zone is
stored. It instead means that when dealing with strings, Postgres will
no longer ignore the time zone portion. It will convert the time zone to
UTC for storage. When transmitted as text, it will be converted to the
database's local time zone. When transmitted as binary, it will be sent
as UTC.

As such, I've provided `ToSql` implementations for basically all flavors
of `DateTime`, but I've only provided a `FromSql` implementation for
`DateTime<UTC>` and `NaiveDateTime`. I have not provided any
implementation for `std::time::SystemTime`, as it implies local time
zone for the machine and we do not have the tools to handle the
conversion in the standard library.

Fixes #106.
Fixes #295.
Fixes #402.
Loading status checks…
b6b56c9

@sgrif sgrif closed this in #409 Aug 18, 2016

@hayathms

This comment has been minimized.

Sign in to view

hayathms commented Nov 14, 2016

Please show how to use this Timestamptz. I am having error infer_schema on db for timestamp pg fields.
need more examples covering a practical pg table implementation. I am trying to migrate old django projects in to Iron+Diesel and having issues here.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment