Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upForce HTTPS on diesel.rs website #1073
Comments
This comment has been minimized.
|
I think the problem is that github pages don't allow you to force https if you're using a custom domain (which of course we are). |
This comment has been minimized.
|
We can configure this in Cloudflare. I think it's already using the
"opportunistic SSL" stuff of http2.
Bastien Orivel <notifications@github.com> schrieb am Sa. 5. Aug. 2017 um
12:32:
… I think the problem is that github pages don't allow you to force https if
you're using a custom domain (which of course we are).
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#1073 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABOX1IYBENsT2QzLwJLihwIdItlsOHnks5sVETGgaJpZM4OuaHP>
.
|
This comment has been minimized.
|
Just had a look and we are using
but not
|
This comment has been minimized.
|
I don't really have a strong feeling for or against forcing it, but we should make sure everything on the domain actually works with HTTPS first. |
This comment has been minimized.
|
@sgrif the only external resources are code.jquery.com and Google Fonts, both are already using HTTPS. The intra-site links seem to assume HTTP, i.e., https://diesel.rs links to http://diesel.rs/guides/. Not sure why. Also, there's a typo in the "canonicical" meta tag here. tl;dr I think we can just enable "Always use HTTPS". |
This comment has been minimized.
|
|
This comment has been minimized.
|
I've been making it a point to ensure as little assumes protocol as possible. So if you're using https, you should stay in https. However, right now our SSL support is implemented by basically having Cloudflare do a giant MITM attack on us. Until we have "proper" SSL support (which is unlikely to happen until github pages supports it for custom domains), I don't think it makes much sense to force its usage. |
MicroJoe commentedAug 5, 2017
•
edited
Because why not, in 2017? I had to manually enter the "s" into the URL to see that the site supports it but by default I arrived on http version using Qwant search engine. Also the website is easy to remember but when I enter it in browser address bar it will send me to the http version.
I have tried to search for any similar issue but only stumbled upon #808. #800 may be related to that too.
Related help page: https://help.github.com/articles/securing-your-github-pages-site-with-https/
Addentum: all links in README redirect to http pages, this is sad.