Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upSet up Travis to test against specific minimum Rust version #1100
Comments
This comment has been minimized.
|
Oh, good catch! Maybe we can set up another travis matrix entry to just build the examples—this way we ensure that the diesel crates can be build (as dependencies) but can use newer features in the test code. (I'm specifically thinking about some pending changes to how |
killercup
added
the
documentation
label
Aug 14, 2017
added a commit
to hobofan/diesel.rs-website
that referenced
this issue
Aug 14, 2017
This comment has been minimized.
|
@diesel-rs/core We need to make a decision on our policy for Rust versions. RFC #1105 does not explicitly state whether increasing the minimum required Rust version is considered a major breaking change or not. I think we need to explicitly decide whether we are allowed to increase our minimum required Rust version or not without a major version bump. My vote is that yes, we should be allowed to increase our minimum supported Rust version in minor versions (but not patch versions). Updating to a new stable version should never be difficult. Future enhancements like specialization, overlapping marker traits, and generic associated types will make new features in Diesel possible, and we should be able to take advantage of that. |
This comment has been minimized.
|
I've been thinking about this for a bit (basically since seeing your tweet), but don't have a definitive answer. Here are some arguments that come to mind:
A pragmatic solution would be to trail a few month behind the latest compiler version. This probably won't help all the people who are using a Linux distro's Rust compiler version, but might cover a signification enough number cases. |
This comment has been minimized.
|
Fixed by #1714 |
hobofan commentedAug 14, 2017
I just noticed that Diesel requires Rust 1.18, not 1.17 as claimed on the website. In order to make sure accidental bumping of minimum Rust versions doesn't happen in the future Travis can be set up to test a specific version of Rust besides the three main release channels.