Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upUse compile_error! #1138
Comments
killercup
added
good first issue
enhancement
help wanted
labels
Sep 1, 2017
This comment has been minimized.
|
@killercup - I'd like to tackle this issue. I think I may be able to also solve #624 while doing this? |
This comment has been minimized.
|
@notryanb it's yours! #624 might be a bit more tricky. Do you have a good idea how to solve it? I could only come up with one medium and one hard way… (see #624 (comment)) |
killercup
added
the
assigned
label
Sep 1, 2017
This comment has been minimized.
|
|
This comment has been minimized.
|
Diesel CLI and Infer Schema should also use this in the places they currently fail to compile when built with 0 features. |
added a commit
to notryanb/diesel
that referenced
this issue
Sep 5, 2017
added a commit
to notryanb/diesel
that referenced
this issue
Sep 5, 2017
added a commit
to notryanb/diesel
that referenced
this issue
Sep 5, 2017
added a commit
to notryanb/diesel
that referenced
this issue
Sep 5, 2017
added a commit
to notryanb/diesel
that referenced
this issue
Sep 6, 2017
added a commit
to notryanb/diesel
that referenced
this issue
Sep 11, 2017
sgrif
closed this
in
e775209
Sep 21, 2017
added a commit
that referenced
this issue
Sep 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
killercup commentedSep 1, 2017
Rust 1.20 stabilized the
compile_error!macro, which means we can finally output useful errors from macros and unusable feature-flag combinations!Here are the places with code comments just waiting to use this macro:
diesel/diesel/src/macros/mod.rs
Lines 406 to 408 in b26472f
diesel/diesel/src/test_helpers.rs
Line 50 in 453d8ff
diesel/diesel_codegen/tests/test_helpers.rs
Line 50 in 453d8ff
diesel/diesel/src/doctest_setup.rs
Line 144 in 4f87b47
diesel/diesel/src/macros/insertable.rs
Line 501 in 148d0e4