Invalid sql generated

[weiznich]

Setup

Versions

• Rust:
• Diesel:
• Database:
• Operating System

Feature Flags

• diesel:
• diesel_codegen:

Problem Description

It is possible to generate invalid sql using diesels buildin query dsl. In detail it is possible to use desc() in group_by calls. (I didn't check any other combinations, probably this could be used in other places too)

What are you trying to accomplish?

I've misstyped some query by accident using group_by instead of order and was surprised this was compiling after noticing this.

What is the expected output?

A compiler error indicating .desc() should not be used in group_by() clauses.

What is the actual output?

A runtime error indicating a invalid sql query

Are you seeing any additional errors?

No

Steps to reproduce

some_table::table.group_by(some_table::some_column.desc()).load(conn)?;

Checklist

• I have already looked over the issue tracker for similar issues.

[sgrif]

group_by is not part of our public API. It has no expected behavior.

diesel/diesel_tests/tests/group_by.rs

Lines 5 to 7 in ceed4c1

	// This test is a shim for a feature which is not sufficiently implemented. It
	// has been added as we have a user who needs a reasonable workaround, but this
	// functionality will change and this test is allowed to change post-1.0