Consider linting test code on CI

[killercup]

We are currently telling contributors to use the bin/test script to test their changes. This script runs a ALL the cargo tests—with clippy enabled. Which means it catches more than our CI setup does, as the Travis only runs the equivalent of cargo clippy.

I think we can tell Travis to compile in a way so code in #[cfg(test)] gets included, but this may conflict with compiling all backends at once.

[sgrif]

I'm actually wondering if we should just remove clippy from bin/test as it increases build times quite a bit. I don't think linting the tests extensively adds nearly as much value

[killercup]

True. On the other hand, it's frustrating to see tests pass locally only to have CI fail on clippy. Do we mention `bin/check` enough in the Contributing Guide?

…

Am 05.09.2017 um 18:38 schrieb Sean Griffin ***@***.***>: I'm actually wondering if we should just remove clippy from bin/test as it increases build times quite a bit. I don't think linting the tests extensively adds nearly as much value — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

[sgrif]

If we removed it from bin/test I would say that we should not lint tests on CI either. Only lint the main code, which is what CI does currently.

[killercup]

Yep. But if people *only* use bin/test, they wont ever see clippy's wonderful suggestions for their changes

…

Am 05.09.2017 um 19:55 schrieb Sean Griffin ***@***.***>: If we removed it from bin/test I would say that we should not lint tests on CI either. Only lint the main code, which is what CI does currently. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

[sgrif]

Given that it's test code, I don't think that's a huge loss

[killercup]

I'm also talking about regular code. With this change, the only way to get clippy to check anything is `bin/check` or being surprised by CI fails

…

Am 05.09.2017 um 21:20 schrieb Sean Griffin ***@***.***>: Given that it's test code, I don't think that's a huge loss — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

[sgrif]

I guess it's a question of whether people are running bin/test or bin/check more.

[killercup]

Well, let's just hope people find bin/check then 😄