Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More code reviewers wanted! #1186

Open
sgrif opened this issue Sep 21, 2017 · 39 comments
Open

More code reviewers wanted! #1186

sgrif opened this issue Sep 21, 2017 · 39 comments

Comments

@sgrif
Copy link
Member

@sgrif sgrif commented Sep 21, 2017

With the push to 1.0, the current pool of reviewers is starting to run low on bandwidth. We're looking for more people to help get involved with code review. You don't need to be familiar with Diesel's internals to help. Most people who have been on the Diesel core team got started by doing code review. If you're unsure what a piece of code does or why it's being done a certain way, just ask! (Make sure that the commit message doesn't answer that question already though). Don't feel like you can't ask a question just because other reviewers might already know the answer. We're happy to help you get up to speed.

@juliusdelta

This comment has been minimized.

Copy link
Contributor

@juliusdelta juliusdelta commented Sep 23, 2017

Nice. Is the best way to get started to just review and add comments/questions to PRs?

@sgrif

This comment has been minimized.

Copy link
Member Author

@sgrif sgrif commented Sep 23, 2017

Yup. If you'd like I can add you to the github group which gets pinged for code review

@juliusdelta

This comment has been minimized.

Copy link
Contributor

@juliusdelta juliusdelta commented Sep 23, 2017

Sure that’d be great!

@toddWannaCode

This comment has been minimized.

Copy link

@toddWannaCode toddWannaCode commented Sep 24, 2017

I am really interested in this but I am just getting started with diesel.

@killercup

This comment has been minimized.

Copy link
Member

@killercup killercup commented Sep 24, 2017

@toddWannaCode that's absolutely fine! Most PRs are quite isolated in scope so you don't need to know everything beforehand. :) Feel free to have a look at and review PRs to get a feel for it, and if you like it, ping me (or another core team member) and we'll add you to the reviewers team.

@leshow

This comment has been minimized.

Copy link

@leshow leshow commented Sep 24, 2017

I'd be interested in jumpiing into some code reviews, if you folks are still looking for people.

@killercup

This comment has been minimized.

Copy link
Member

@killercup killercup commented Sep 25, 2017

@toddWannaCode

This comment has been minimized.

Copy link

@toddWannaCode toddWannaCode commented Sep 25, 2017

Hey I would be like to be a member of the Reviewers team. Thanks. @killercup

@killercup

This comment has been minimized.

Copy link
Member

@killercup killercup commented Sep 25, 2017

@toddWannaCode, welcome to the league of extraordinary reviewers! :)

@leshow

This comment has been minimized.

Copy link

@leshow leshow commented Sep 25, 2017

@killercup Sure, sounds good.

@killercup

This comment has been minimized.

Copy link
Member

@killercup killercup commented Sep 25, 2017

@leshow, welcome to the Four Nine Horsemen of the Code Review!

@ecasilla

This comment has been minimized.

Copy link

@ecasilla ecasilla commented Sep 26, 2017

Count me in also. I would love to help anyway I can.

@killercup

This comment has been minimized.

Copy link
Member

@killercup killercup commented Sep 26, 2017

@ecasilla, thank you for joining the Order of Magnitude!

@ecasilla

This comment has been minimized.

Copy link

@ecasilla ecasilla commented Sep 26, 2017

@killercup How will the mentoring work exactly is there a gitter for the core team?

@sgrif

This comment has been minimized.

Copy link
Member Author

@sgrif sgrif commented Sep 26, 2017

@ecasilla You can ask questions either in the public gitter or as comments on the PRs you're trying to review (feel free to ask questions after things have been closed/merged as well)

@gsquire

This comment has been minimized.

Copy link
Contributor

@gsquire gsquire commented Sep 29, 2017

I don't have much experience in the codebase but I'd like to help review.

@jbcden

This comment has been minimized.

Copy link
Contributor

@jbcden jbcden commented Jan 7, 2018

I'm a bit late to the party and I haven't really gotten a chance to use diesel, but I'm trying to get into Rust more and would love to help with reviews!

@bahlo

This comment has been minimized.

Copy link
Member

@bahlo bahlo commented Jan 10, 2018

Hey, I'd also like to be in the review team.

@retep007

This comment has been minimized.

Copy link

@retep007 retep007 commented Feb 3, 2018

Hi, count me in

@sgrif

This comment has been minimized.

Copy link
Member Author

@sgrif sgrif commented Feb 3, 2018

@retep007 I've added you to the team -- You'll get pinged on future PRs, but feel free to review any of the open PRs in the mean time. There's quite a few open right now.

@sgrif

This comment has been minimized.

Copy link
Member Author

@sgrif sgrif commented Feb 3, 2018

(Note: Everyone who's replied to this has been added shortly after replying, I'm only singling that person out because there happens to have been an extremely high volume of PRs opened in the past 24 hours and I assumed the were around right now)

@sgrif

This comment has been minimized.

Copy link
Member Author

@sgrif sgrif commented Feb 3, 2018

I should also mention -- If anyone tries to review a PR, and feels like they don't understand enough to properly review it, please ask questions on the PR. We don't mind explaining things that aren't clear, and hearing what needs more context before the PR is opened is extremely helpful.

@logotie

This comment has been minimized.

Copy link

@logotie logotie commented Mar 1, 2018

Hello all, is there any chance I could please be added also? I am however very much a beginner with Rust :)

@sgrif

This comment has been minimized.

Copy link
Member Author

@sgrif sgrif commented Apr 26, 2018

Hey folks, just a heads up, I did some cleanup tonight. Anyone who hasn't commented on an issue in the past month will have been removed. If you'd like to be re-added, please comment again on this issue.

@JohnTitor

This comment has been minimized.

Copy link
Member

@JohnTitor JohnTitor commented Apr 15, 2019

Hi @sgrif, let me help you with reviewing! Diesel is used in my work, so improving Diesel is also important task.

@weiznich

This comment has been minimized.

Copy link
Member

@weiznich weiznich commented Apr 17, 2019

@JohnTitor I've added you to the reviewer team.

@AlterionX

This comment has been minimized.

Copy link

@AlterionX AlterionX commented Sep 25, 2019

I would like to do some code review work! It's been lots of fun using Diesel, and I would like to get a good grasp of the internals.

@weiznich

This comment has been minimized.

Copy link
Member

@weiznich weiznich commented Sep 25, 2019

@AlterionX I've added you to the corresponding team. You should now get notifications on requested reviews.
Feel free to ask questions everywhere where something is unclear.

@Razican

This comment has been minimized.

Copy link
Contributor

@Razican Razican commented Nov 11, 2019

Hi! I would like to be added as a reviewer. I'm not familiar with Diesel internals, but I know Rust and would like to help and learn :)

@weiznich

This comment has been minimized.

Copy link
Member

@weiznich weiznich commented Nov 11, 2019

@Razican I've added you to the corresponding team. You should now get notifications on newly requested reviews. If you want you could also check existing PR's. Feel free to ask questions anywhere where something is unclear, we will try to explain it 😉

If you don't want to be at the reviewer team any more at some point of time just tell us that and we will remove you from the list that get's pinged on new PR's.

@FlorentinDUBOIS

This comment has been minimized.

Copy link

@FlorentinDUBOIS FlorentinDUBOIS commented Feb 6, 2020

Hi! I will be glad to help you to review some pull requests, I'm not familiar with diesel but I have played a lot with hyper and tokio. I think I could help :)

@weiznich

This comment has been minimized.

Copy link
Member

@weiznich weiznich commented Feb 6, 2020

@FlorentinDUBOIS I've sent you a invitation for the reviewer team. You should now get notifications on newly requested reviews. If you want you could also check existing PR's. Feel free to ask questions anywhere where something is unclear, we will try to explain it 😉

If you don't want to be at the reviewer team any more at some point of time just tell us that and we will remove you from the list that get's pinged on new PR's.

@danidoni

This comment has been minimized.

Copy link

@danidoni danidoni commented Feb 7, 2020

Hi! I'm interested also! I know a bit of Rust, but I'm interested into learning and finding a place to contribute 😁

@weiznich

This comment has been minimized.

Copy link
Member

@weiznich weiznich commented Feb 7, 2020

@danidoni I've sent you an invitation. As mentioned above feel free to ask questions anywhere where something is unclear. It's totally fine (and encouraged) to ask at a PR how something works.

@jdlambert

This comment has been minimized.

Copy link
Member

@jdlambert jdlambert commented Feb 7, 2020

I'm interested in reviewing PRs as well!

@weiznich

This comment has been minimized.

Copy link
Member

@weiznich weiznich commented Feb 7, 2020

@jdlambert I've sent you an invitation. Everything else as written above.

@synixebrett

This comment has been minimized.

Copy link

@synixebrett synixebrett commented Feb 9, 2020

I'm new to diesel but been using Rust for quiet a while, if you need more added shoot me an invite please

@weiznich

This comment has been minimized.

Copy link
Member

@weiznich weiznich commented Feb 9, 2020

@synixebrett I've sent you an invitation. Everything else as written above.

@weiznich

This comment has been minimized.

Copy link
Member

@weiznich weiznich commented Feb 10, 2020

@diesel-rs/reviewers We are interested in getting reviews on the PR's in the diesel 2.0 milestone. I know some of them are quite complicated, so especially there: Please ask questions about everything that is unclear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
You can’t perform that action at this time.