Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upThe `changeset` macro should be a compiler annotation #12
Comments
sgrif
added this to the 0.1 milestone
Nov 28, 2015
sgrif
closed this
in
c4b8a34
Nov 28, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
sgrif commentedNov 28, 2015
Documenting in case anyone wants to get involved. This is the last macro being invoked from our integration tests that needs to go away for 0.1 I intend for this to be
#[can_update="users"]. This annotation should basically do what the macro does today, including all columns, but should specifically exclude the primary key of the table from the changeset.As part of this, I think we should group all our non-derive annotations into a single namespace with each just being a key/value pair. e.g.
#[yaqb(inserable_into("users"), can_update("users"))]. That change should affect#[column_name]as well. That can be a separate PR that pre-dates this change, part of this change, or just not done at all. It's not a 0.1 blocker.