/diesel

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename `enable_multi_table_joins!` to `allow_tables_to_appear_in_same_query!` #1236

Closed
sgrif opened this Issue Oct 6, 2017 · 1 comment

Comments

Assignees
No one assigned
Labels
Projects
None yet
Milestone
  1.0
2 participants
@sgrif @bippityboppity
@sgrif
Member

sgrif commented Oct 6, 2017

We'll need to deprecate the old macro rather than just removing it immediately.

@sgrif sgrif added breaking change good first issue labels Oct 6, 2017

@sgrif sgrif added this to the 1.0 milestone Oct 6, 2017

@bippityboppity

This comment has been minimized.

Sign in to view
Contributor

bippityboppity commented Oct 8, 2017

I'd like to give this a try 🙂

@bippityboppity bippityboppity referenced this issue Oct 8, 2017

Merged

Rename `enable_multi_table_joins!` to `allow_tables_to_appear_in_same_query!` #1246

@sgrif sgrif closed this in #1246 Oct 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment